From: Wolfram Sang <wsa@the-dreams.de>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
GregKH <greg@kroah.com>
Subject: Re: [PATCH] eeprom: at24: tweak the loop_until_timeout() macro
Date: Mon, 18 Jul 2016 20:11:34 +0200 [thread overview]
Message-ID: <20160718181134.GA1973@katana> (raw)
In-Reply-To: <1468780806-13034-1-git-send-email-bgolaszewski@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On Sun, Jul 17, 2016 at 08:40:06PM +0200, Bartosz Golaszewski wrote:
> loop_until_timeout() replaced a do {} while loop in the at24 driver
> with a for loop which, under certain circumstances (such as heavy load
> or low value of the write_timeout argument), can lead to the code in
> the loop never being executed.
>
> Make sure that at least one iteration of the code enclosed within
> loop_until_timeout() is always executed.
>
> Suggested-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-18 18:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-17 18:40 [PATCH] eeprom: at24: tweak the loop_until_timeout() macro Bartosz Golaszewski
2016-07-18 18:11 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718181134.GA1973@katana \
--to=wsa@the-dreams.de \
--cc=andrew@lunn.ch \
--cc=bgolaszewski@baylibre.com \
--cc=greg@kroah.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).