From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH v2 3/3] acpi spi: Initialize modalias from of_compatible Date: Tue, 19 Jul 2016 10:08:02 +0300 Message-ID: <20160719070802.GO14693@lahna.fi.intel.com> References: <1d26e956f12fcd86ad915659adeb86e242b96ac7.1468409668.git.leonard.crestez@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: Crestez Dan Leonard , ACPI Devel Maling List , "Rafael J. Wysocki" , Jarkko Nikula , Len Brown , linux-i2c , Wolfram Sang , linux-spi , Mark Brown , Linux Kernel Mailing List , Octavian Purdila List-Id: linux-i2c@vger.kernel.org On Wed, Jul 13, 2016 at 02:22:02PM +0200, Rafael J. Wysocki wrote: > On Wed, Jul 13, 2016 at 1:53 PM, Crestez Dan Leonard > wrote: > > When using devicetree spi_device.modalias is set to the compatible > > string with the vendor prefix removed. For SPI devices described via > > ACPI the i2c_board_info.type string is initialized by acpi_device_hid. > > When using ACPI and DT ids this string ends up something like "PRP0001". > > > > Change acpi_register_spi_device to use the of_compatible property if > > present. This makes it easier to instantiate spi drivers through ACPI > > with DT ids. > > > > Signed-off-by: Crestez Dan Leonard > > Same as for the i2c patch: it looks good to me, but I'd prefer to get > a word from Mika on it too. Reviewed-by: Mika Westerberg