* Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting [not found] ` <578C9843.10408@nvidia.com> @ 2016-07-18 13:30 ` Jonathan Cameron [not found] ` <dff1e871-de49-654f-5e9b-c9b230a35b0a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Jonathan Cameron @ 2016-07-18 13:30 UTC (permalink / raw) To: Laxman Dewangan, Alison Schofield Cc: knaack.h, lars, pmeerw, linux-iio, linux-kernel, Wolfram Sang, Linux I2C On 18/07/16 09:50, Laxman Dewangan wrote: > > On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: >> I2C_CLASS_HWMON is for a hardware monitoring chip wanting >> auto-detection. IIO drivers don't typically use .class. >> Remove it. >> >> Signed-off-by: Alison Schofield <amsfield22@gmail.com> >> Cc: Daniel Baluta <daniel.baluta@gmail.com> >> > > Agree. > Acked-by: Laxman Dewangan <ldewangan@nvidia.com> Any resulting ABI change from dropping it? I don't think so, as it doesn't support detection anyway, but best to be sure ;) > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <dff1e871-de49-654f-5e9b-c9b230a35b0a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]
* Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting [not found] ` <dff1e871-de49-654f-5e9b-c9b230a35b0a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> @ 2016-07-19 7:13 ` Wolfram Sang 2016-07-20 15:08 ` Jonathan Cameron 0 siblings, 1 reply; 4+ messages in thread From: Wolfram Sang @ 2016-07-19 7:13 UTC (permalink / raw) To: Jonathan Cameron Cc: Laxman Dewangan, Alison Schofield, knaack.h-Mmb7MZpHnFY, lars-Qo5EllUWu/uELgA04lAiVw, pmeerw-jW+XmwGofnusTnJN9+BGXg, linux-iio-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Linux I2C [-- Attachment #1: Type: text/plain, Size: 823 bytes --] On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote: > On 18/07/16 09:50, Laxman Dewangan wrote: > > > > On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: > >> I2C_CLASS_HWMON is for a hardware monitoring chip wanting > >> auto-detection. IIO drivers don't typically use .class. > >> Remove it. > >> > >> Signed-off-by: Alison Schofield <amsfield22-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> Cc: Daniel Baluta <daniel.baluta-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > >> > > > > Agree. > > Acked-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > Any resulting ABI change from dropping it? What do you mean with ABI? This is only relevant for "automatic" instantiation. From me: Acked-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting 2016-07-19 7:13 ` Wolfram Sang @ 2016-07-20 15:08 ` Jonathan Cameron 2016-07-24 11:30 ` Jonathan Cameron 0 siblings, 1 reply; 4+ messages in thread From: Jonathan Cameron @ 2016-07-20 15:08 UTC (permalink / raw) To: Wolfram Sang Cc: Laxman Dewangan, Alison Schofield, knaack.h, lars, pmeerw, linux-iio, linux-kernel, Linux I2C On 19/07/16 08:13, Wolfram Sang wrote: > On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote: >> On 18/07/16 09:50, Laxman Dewangan wrote: >>> >>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: >>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting >>>> auto-detection. IIO drivers don't typically use .class. >>>> Remove it. >>>> >>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com> >>>> Cc: Daniel Baluta <daniel.baluta@gmail.com> >>>> >>> >>> Agree. >>> Acked-by: Laxman Dewangan <ldewangan@nvidia.com> >> Any resulting ABI change from dropping it? > > What do you mean with ABI? This is only relevant for "automatic" > instantiation. Cool, I was just being paranoid and didn't have time to check! Thanks, Jonathan > From me: > > Acked-by: Wolfram Sang <wsa@the-dreams.de> > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting 2016-07-20 15:08 ` Jonathan Cameron @ 2016-07-24 11:30 ` Jonathan Cameron 0 siblings, 0 replies; 4+ messages in thread From: Jonathan Cameron @ 2016-07-24 11:30 UTC (permalink / raw) To: Wolfram Sang Cc: Laxman Dewangan, Alison Schofield, knaack.h, lars, pmeerw, linux-iio, linux-kernel, Linux I2C On 20/07/16 16:08, Jonathan Cameron wrote: > On 19/07/16 08:13, Wolfram Sang wrote: >> On Mon, Jul 18, 2016 at 02:30:46PM +0100, Jonathan Cameron wrote: >>> On 18/07/16 09:50, Laxman Dewangan wrote: >>>> >>>> On Saturday 16 July 2016 07:58 AM, Alison Schofield wrote: >>>>> I2C_CLASS_HWMON is for a hardware monitoring chip wanting >>>>> auto-detection. IIO drivers don't typically use .class. >>>>> Remove it. >>>>> >>>>> Signed-off-by: Alison Schofield <amsfield22@gmail.com> >>>>> Cc: Daniel Baluta <daniel.baluta@gmail.com> >>>>> >>>> >>>> Agree. >>>> Acked-by: Laxman Dewangan <ldewangan@nvidia.com> >>> Any resulting ABI change from dropping it? >> >> What do you mean with ABI? This is only relevant for "automatic" >> instantiation. > Cool, I was just being paranoid and didn't have time to check! > > Thanks, > > Jonathan >> From me: >> >> Acked-by: Wolfram Sang <wsa@the-dreams.de> >> > Applied to the togreg branch of iio.git - initially pushed out as testing for the autoubuilders to play with it. thanks, Jonathan > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-07-24 11:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160716022831.GA7636@d830.WORKGROUP>
[not found] ` <578C9843.10408@nvidia.com>
2016-07-18 13:30 ` [PATCH] staging: iio: light: isl29018/28: remove I2C_CLASS_HWMON .class setting Jonathan Cameron
[not found] ` <dff1e871-de49-654f-5e9b-c9b230a35b0a-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-19 7:13 ` Wolfram Sang
2016-07-20 15:08 ` Jonathan Cameron
2016-07-24 11:30 ` Jonathan Cameron
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).