* [PATCH] i2c: i2c-smbus: drop useless stubs
@ 2016-07-19 11:15 Jean Delvare
2016-07-19 11:24 ` Benjamin Tissoires
2016-07-22 7:08 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2016-07-19 11:15 UTC (permalink / raw)
To: Linux I2C; +Cc: Benjamin Tissoires, Wolfram Sang
Drivers which use the SMBus extensions select I2C_SMBUS, so the
stubs are not needed.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Wolfram Sang <wsa@the-dreams.de>
---
include/linux/i2c-smbus.h | 15 ---------------
1 file changed, 15 deletions(-)
--- linux-4.7-rc7.orig/include/linux/i2c-smbus.h 2016-07-19 13:06:08.873469372 +0200
+++ linux-4.7-rc7/include/linux/i2c-smbus.h 2016-07-19 13:11:46.265359168 +0200
@@ -73,23 +73,8 @@ struct smbus_host_notify {
u8 addr;
};
-#if IS_ENABLED(CONFIG_I2C_SMBUS)
struct smbus_host_notify *i2c_setup_smbus_host_notify(struct i2c_adapter *adap);
int i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify,
unsigned short addr, unsigned int data);
-#else
-static inline struct smbus_host_notify *
-i2c_setup_smbus_host_notify(struct i2c_adapter *adap)
-{
- return NULL;
-}
-
-static inline int
-i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify,
- unsigned short addr, unsigned int data)
-{
- return 0;
-}
-#endif /* I2C_SMBUS */
#endif /* _LINUX_I2C_SMBUS_H */
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: i2c-smbus: drop useless stubs
2016-07-19 11:15 [PATCH] i2c: i2c-smbus: drop useless stubs Jean Delvare
@ 2016-07-19 11:24 ` Benjamin Tissoires
2016-07-22 7:08 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2016-07-19 11:24 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C, Wolfram Sang
On Jul 19 2016 or thereabouts, Jean Delvare wrote:
> Drivers which use the SMBus extensions select I2C_SMBUS, so the
> stubs are not needed.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> ---
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> include/linux/i2c-smbus.h | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> --- linux-4.7-rc7.orig/include/linux/i2c-smbus.h 2016-07-19 13:06:08.873469372 +0200
> +++ linux-4.7-rc7/include/linux/i2c-smbus.h 2016-07-19 13:11:46.265359168 +0200
> @@ -73,23 +73,8 @@ struct smbus_host_notify {
> u8 addr;
> };
>
> -#if IS_ENABLED(CONFIG_I2C_SMBUS)
> struct smbus_host_notify *i2c_setup_smbus_host_notify(struct i2c_adapter *adap);
> int i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify,
> unsigned short addr, unsigned int data);
> -#else
> -static inline struct smbus_host_notify *
> -i2c_setup_smbus_host_notify(struct i2c_adapter *adap)
> -{
> - return NULL;
> -}
> -
> -static inline int
> -i2c_handle_smbus_host_notify(struct smbus_host_notify *host_notify,
> - unsigned short addr, unsigned int data)
> -{
> - return 0;
> -}
> -#endif /* I2C_SMBUS */
>
> #endif /* _LINUX_I2C_SMBUS_H */
>
>
> --
> Jean Delvare
> SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: i2c-smbus: drop useless stubs
2016-07-19 11:15 [PATCH] i2c: i2c-smbus: drop useless stubs Jean Delvare
2016-07-19 11:24 ` Benjamin Tissoires
@ 2016-07-22 7:08 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2016-07-22 7:08 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C, Benjamin Tissoires
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On Tue, Jul 19, 2016 at 01:15:49PM +0200, Jean Delvare wrote:
> Drivers which use the SMBus extensions select I2C_SMBUS, so the
> stubs are not needed.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Cc: Wolfram Sang <wsa@the-dreams.de>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-22 7:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19 11:15 [PATCH] i2c: i2c-smbus: drop useless stubs Jean Delvare
2016-07-19 11:24 ` Benjamin Tissoires
2016-07-22 7:08 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).