From: Wolfram Sang <wsa@the-dreams.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: dianders@chromium.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise
Date: Mon, 25 Jul 2016 22:45:16 +0200 [thread overview]
Message-ID: <20160725204516.GB1698@katana> (raw)
In-Reply-To: <1469477464-28735-1-git-send-email-linux@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
> - else if (resp->i2c_status & EC_I2C_STATUS_ERROR)
> + else if (resp->i2c_status & EC_I2C_STATUS_NAK)
> + return -ENXIO;
> + else if (resp->i2c_status)
> return -EREMOTEIO;
Since you mentioned Documentation/i2c/fault-codes already: -EIO?
>
> /* Other side could send us back fewer messages, but not more */
> @@ -223,7 +225,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
>
> result = ec_i2c_parse_response(msg->data, i2c_msgs, &num);
> if (result < 0) {
> - dev_err(dev, "Error parsing EC i2c message %d\n", result);
> + dev_dbg(dev, "Error parsing EC i2c message %d\n", result);
For me, this message can go entirely, but I'll leave this up to you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-25 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 20:11 [PATCH] i2c: i2c-cros-ec-tunnel: Reduce logging noise Guenter Roeck
2016-07-25 20:45 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160725204516.GB1698@katana \
--to=wsa@the-dreams.de \
--cc=dianders@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).