From: Wolfram Sang <wsa@the-dreams.de>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
adi-buildroot-devel@lists.sourceforge.net,
linuxppc-dev@lists.ozlabs.org, linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, linux-omap@vger.kernel.org,
linux-rockchip@lists.infradead.org, kernel@stlinux.com,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] i2c: don't print error when adding adapter fails
Date: Tue, 9 Aug 2016 16:39:15 +0200 [thread overview]
Message-ID: <20160809143915.GB1666@katana> (raw)
In-Reply-To: <32d25618-83f6-b876-07b0-adb988516173@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
> >@@ -550,15 +550,10 @@ static int uniphier_fi2c_probe(struct platform_device *pdev)
> > }
> >
> > ret = i2c_add_adapter(&priv->adap);
> >- if (ret) {
> >- dev_err(dev, "failed to add I2C adapter\n");
> >- goto err;
> >- }
> >-
> >-err:
> > if (ret)
> > clk_disable_unprepare(priv->clk);
> >
> >+ err:
>
> You sure about that one ? It leaves the clock enabled in some of the error paths.
Uh, ehrm, where is the brown paper bag? Thanks, Guenter!
> Note: I dropped all individuals from Cc:; my mailer refused to accept the reply because there
> were too many.
Yes, the disadvantage of not breaking out.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-09 14:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:36 [PATCH] i2c: don't print error when adding adapter fails Wolfram Sang
[not found] ` <1470742581-12971-1-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
2016-08-09 11:36 ` Wolfram Sang
2016-08-09 11:57 ` Uwe Kleine-König
2016-08-09 13:59 ` Wolfram Sang
2016-08-09 12:13 ` Heiko Stübner
2016-08-09 12:55 ` Neil Horman
[not found] ` <20160809125522.GA15676-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2016-08-10 2:56 ` Zhang, Sonic
2016-08-09 13:31 ` Guenter Roeck
2016-08-09 14:39 ` Wolfram Sang [this message]
2016-08-09 16:36 ` Vladimir Zapolskiy
2016-08-10 8:32 ` Krzysztof Kozlowski
[not found] ` <1470742581-12971-2-git-send-email-wsa-dev-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
2016-08-09 11:47 ` Grygorii Strashko
2016-08-09 11:48 ` Peter Korsgaard
2016-08-09 12:58 ` Thierry Reding
2016-08-09 16:15 ` Ray Jui
2016-08-10 6:17 ` Ludovic Desroches
2016-08-10 8:34 ` Laxman Dewangan
2016-10-05 15:17 ` Jean Delvare
2016-08-09 16:45 ` Joachim Eastwood
2016-08-10 6:50 ` [STLinux Kernel] " Patrice Chotard
2016-08-14 22:17 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809143915.GB1666@katana \
--to=wsa@the-dreams.de \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=kernel@stlinux.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).