From: Wolfram Sang <wsa@the-dreams.de>
To: Abylay Ospan <aospan@netup.ru>
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Sergey Kozlov <serjk@netup.ru>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/4] media: pci: netup_unidvb: don't print error when adding adapter fails
Date: Tue, 9 Aug 2016 16:58:56 +0200 [thread overview]
Message-ID: <20160809145856.GC1666@katana> (raw)
In-Reply-To: <CAK3bHNWmxQsAtefcUocoOcEwtWnpptiVxzhXR-+jVU524RmnPw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
> Sometimes it better to show more message - especially in error conditions :)
Sure, if they contain additional information.
> btw, do you make sanity check for "duplicate" log messages ?
I checked all error messages if they contain additional information.
> ret = i2c_add_adapter(&i2c->adap);
> - if (ret) {
> - dev_err(&ndev->pci_dev->dev,
> - "%s(): failed to add I2C adapter\n", __func__);
> + if (ret)
> return ret;
> - }
IMHO, this one doesn't. __func__ is not helpful to users. And the error
messages in the core will make sure that a developer knows where to
start looking.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-09 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 11:35 [PATCH 0/4] media: don't print error when adding adapter fails Wolfram Sang
2016-08-09 11:35 ` [PATCH 1/4] media: pci: netup_unidvb: " Wolfram Sang
[not found] ` <CAK3bHNWmxQsAtefcUocoOcEwtWnpptiVxzhXR-+jVU524RmnPw@mail.gmail.com>
2016-08-09 14:58 ` Wolfram Sang [this message]
2016-08-10 14:41 ` Abylay Ospan
2016-08-10 14:56 ` Wolfram Sang
2016-08-10 15:06 ` Abylay Ospan
2016-08-09 11:35 ` [PATCH 2/4] media: pci: pt3: " Wolfram Sang
2016-08-09 11:35 ` [PATCH 3/4] media: platform: exynos4-is: fimc-is-i2c: " Wolfram Sang
2016-08-09 11:35 ` [PATCH 4/4] media: usb: dvb-usb-v2: dvb_usb_core: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809145856.GC1666@katana \
--to=wsa@the-dreams.de \
--cc=aospan@netup.ru \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=serjk@netup.ru \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).