From: Wolfram Sang <wsa@the-dreams.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-tools: fix feature test macros for glibc >= 2.20
Date: Tue, 9 Aug 2016 22:40:11 +0200 [thread overview]
Message-ID: <20160809204011.GA1644@katana> (raw)
In-Reply-To: <20160803132311.59d53ad7@endymion>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
> > /* For strdup and snprintf */
> > -#define _BSD_SOURCE 1
> > +#define _BSD_SOURCE 1 /* for glibc < 2.19 */
> > +#define _DEFAULT_SOURCE 1 /* for glibc >= 2.20 */
>
> Actually >= 2.19 if I read the web page you mentioned (which has the
> same "bug") correctly.
On the web page it is not a bug, because it says "If ... you must
support glibc < 2.19 and glibc >= 2.20 then define all three
unconditionally". This is correct since 2.19 works with both options.
However, I should probably use >= 2.19 and <= 2.19 here.
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> Again the 3.1 branch would need the same fix.
Yes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-09 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 8:43 [PATCH] i2c-tools: fix feature test macros for glibc >= 2.20 Wolfram Sang
2016-08-03 11:23 ` Jean Delvare
2016-08-09 20:40 ` Wolfram Sang [this message]
2016-08-12 18:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809204011.GA1644@katana \
--to=wsa@the-dreams.de \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).