From: kbuild test robot <fengguang.wu@intel.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: kbuild-all@01.org, linux-i2c@vger.kernel.org
Subject: [wsa:strings/usb_alloc_urb 52/80] drivers/net/wireless/realtek/rtlwifi/usb.c:907:19: warning: unused variable 'rtlpriv'
Date: Wed, 10 Aug 2016 01:10:56 +0800 [thread overview]
Message-ID: <201608100151.e3SI2xAH%fengguang.wu@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3771 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git strings/usb_alloc_urb
head: 17ffacee4e8ad02cffcd5e67e2d6de3ee252d008
commit: 455e91249f8815de7e4ec378e785bf8bca1369da [52/80] net: wireless: realtek: rtlwifi: usb: don't print error when allocating urb fails
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 455e91249f8815de7e4ec378e785bf8bca1369da
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All warnings (new ones prefixed by >>):
drivers/net/wireless/realtek/rtlwifi/usb.c: In function '_rtl_usb_tx_urb_setup':
>> drivers/net/wireless/realtek/rtlwifi/usb.c:907:19: warning: unused variable 'rtlpriv' [-Wunused-variable]
struct rtl_priv *rtlpriv = rtl_priv(hw);
^
vim +/rtlpriv +907 drivers/net/wireless/realtek/rtlwifi/usb.c
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 891 struct rtl_usb *rtlusb = (struct rtl_usb *)info->rate_driver_data[0];
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 892 struct ieee80211_hw *hw = usb_get_intfdata(rtlusb->intf);
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 893 int err;
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 894
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 895 if (unlikely(IS_USB_STOP(rtlusb)))
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 896 return;
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 897 err = _usb_tx_post(hw, urb, skb);
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 898 if (err) {
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 899 /* Ignore error and keep issuiing other urbs */
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 900 return;
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 901 }
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 902 }
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 903
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 904 static struct urb *_rtl_usb_tx_urb_setup(struct ieee80211_hw *hw,
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 905 struct sk_buff *skb, u32 ep_num)
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 906 {
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 @907 struct rtl_priv *rtlpriv = rtl_priv(hw);
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 908 struct rtl_usb *rtlusb = rtl_usbdev(rtl_usbpriv(hw));
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 909 struct urb *_urb;
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 910
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 911 WARN_ON(NULL == skb);
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 912 _urb = usb_alloc_urb(0, GFP_ATOMIC);
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 913 if (!_urb) {
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 914 kfree_skb(skb);
2ca20f79 drivers/net/wireless/rtlwifi/usb.c George 2011-02-11 915 return NULL;
:::::: The code at line 907 was first introduced by commit
:::::: 2ca20f79e0d895489ae2f79fa321077e5ee2981d rtlwifi: Add usb driver
:::::: TO: George <george0505@realtek.com>
:::::: CC: John W. Linville <linville@tuxdriver.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 46017 bytes --]
reply other threads:[~2016-08-09 17:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201608100151.e3SI2xAH%fengguang.wu@intel.com \
--to=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).