From: Wolfram Sang <wsa@the-dreams.de>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] eeprom: at24: check if the chip is functional in probe()
Date: Thu, 11 Aug 2016 17:55:33 +0200 [thread overview]
Message-ID: <20160811155533.GA2185@katana> (raw)
In-Reply-To: <CAMpxmJVgvxXfdp97y-ud=35H+X13wFR22kzeLS4FnDZQ7NT2sA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
> >> + err = at24_read(at24, 0, &c, 1);
> >
> > Can't we do this before registering dummy clients and nvmem registration?
> >
>
> It should be ok for nvmem, but I'm not sure about the clients:
> at24_translate_offset() will return one of the registered client
> structures and though it should generally work for the first byte (it
> would always be at24->client[0]), it won't be "rock solid" anymore.
Agreed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-11 15:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-10 13:54 [PATCH] eeprom: at24: check if the chip is functional in probe() Bartosz Golaszewski
2016-08-10 14:07 ` Wolfram Sang
2016-08-11 15:09 ` Bartosz Golaszewski
2016-08-11 15:55 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160811155533.GA2185@katana \
--to=wsa@the-dreams.de \
--cc=bgolaszewski@baylibre.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).