From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>,
Steven.Hill@caviumnetworks.com
Subject: Re: [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support
Date: Tue, 23 Aug 2016 23:52:47 +0200 [thread overview]
Message-ID: <20160823215247.GD28936@hardcore> (raw)
In-Reply-To: <20160823213948.GH20872@katana>
On Tue, Aug 23, 2016 at 11:39:48PM +0200, Wolfram Sang wrote:
> On Tue, Aug 23, 2016 at 11:28:59PM +0200, Jan Glauber wrote:
> > On Tue, Aug 23, 2016 at 10:57:25PM +0200, Wolfram Sang wrote:
> > > On Wed, Jun 15, 2016 at 03:51:30PM +0200, Jan Glauber wrote:
> > > > Add SMBUS alert interrupt support. For now only device tree is
> > > > supported for specifying the alert. In case of ACPI an error
> > > > is returned.
> > > >
> > > > Signed-off-by: Jan Glauber <jglauber@cavium.com>
> > >
> > > What about 'select I2C_SMBUS' in Kconfig and skip all the ifdeffery?
> > >
> >
> > Wouldn't that prevent a distribution that has I2C_HELPER_AUTO set
> > from enabling the ThunderX i2c driver at all?
>
> From commit e2ca307439fb9df922c3e8891289a2ac05812fb7:
>
> ...
> Bus drivers which implement SMBus alert should select this option, so
> in most cases this option is hidden and the user doesn't have to care
> about it.
>
OK, makes sense. I'll remove the ifdef's.
next prev parent reply other threads:[~2016-08-23 21:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 13:51 [PATCH v10 0/8] i2c-octeon and i2c-thunderx driver Jan Glauber
2016-06-15 13:51 ` [PATCH v10 1/8] i2c: octeon: Rename driver to prepare for split Jan Glauber
2016-06-15 13:51 ` [PATCH v10 2/8] i2c: octeon: Split the driver into two parts Jan Glauber
2016-06-15 13:51 ` [PATCH v10 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber
2016-08-23 20:36 ` Wolfram Sang
2016-08-23 20:39 ` Wolfram Sang
2016-08-23 21:09 ` Jan Glauber
2016-08-23 21:22 ` Jan Glauber
2016-06-15 13:51 ` [PATCH v10 4/8] i2c: thunderx: Add SMBUS alert support Jan Glauber
2016-08-23 20:57 ` Wolfram Sang
2016-08-23 21:28 ` Jan Glauber
2016-08-23 21:39 ` Wolfram Sang
2016-08-23 21:52 ` Jan Glauber [this message]
2016-06-15 13:51 ` [PATCH v10 5/8] i2c: octeon,thunderx: Move register offsets to struct Jan Glauber
2016-06-15 13:51 ` [PATCH v10 6/8] i2c: octeon: Sort include files alphabetically Jan Glauber
2016-06-15 13:51 ` [PATCH v10 7/8] i2c: cavium: Use booleon values for booleon variables Jan Glauber
2016-06-15 13:51 ` [PATCH v10 8/8] i2c: octeon: thunderx: Add MAINTAINERS entry Jan Glauber
2016-08-23 21:00 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160823215247.GD28936@hardcore \
--to=jan.glauber@caviumnetworks.com \
--cc=Steven.Hill@caviumnetworks.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).