* [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error
@ 2016-08-24 9:19 Wolfram Sang
2016-08-24 9:19 ` [PATCH 2/2] i2c: rcar: " Wolfram Sang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-08-24 9:19 UTC (permalink / raw)
To: linux-i2c
Cc: linux-renesas-soc, Geert Uytterhoeven, Niklas Söderlund,
Wolfram Sang
We must use the same device we used for mapping.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-sh_mobile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c
index 6fb3e264599229..05b1eeab9cf5f6 100644
--- a/drivers/i2c/busses/i2c-sh_mobile.c
+++ b/drivers/i2c/busses/i2c-sh_mobile.c
@@ -610,7 +610,7 @@ static void sh_mobile_i2c_xfer_dma(struct sh_mobile_i2c_data *pd)
return;
dma_addr = dma_map_single(chan->device->dev, pd->msg->buf, pd->msg->len, dir);
- if (dma_mapping_error(pd->dev, dma_addr)) {
+ if (dma_mapping_error(chan->device->dev, dma_addr)) {
dev_dbg(pd->dev, "dma map failed, using PIO\n");
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] i2c: rcar: use proper device with dma_mapping_error
2016-08-24 9:19 [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error Wolfram Sang
@ 2016-08-24 9:19 ` Wolfram Sang
2016-08-25 7:59 ` Geert Uytterhoeven
2016-08-25 16:50 ` Wolfram Sang
2016-08-25 7:59 ` [PATCH 1/2] i2c: sh_mobile: " Geert Uytterhoeven
2016-08-25 16:50 ` Wolfram Sang
2 siblings, 2 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-08-24 9:19 UTC (permalink / raw)
To: linux-i2c
Cc: linux-renesas-soc, Geert Uytterhoeven, Niklas Söderlund,
Wolfram Sang
We must use the same device we used for mapping.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/busses/i2c-rcar.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
index 52407f3c9e1cce..9bd849dacee872 100644
--- a/drivers/i2c/busses/i2c-rcar.c
+++ b/drivers/i2c/busses/i2c-rcar.c
@@ -378,7 +378,7 @@ static void rcar_i2c_dma(struct rcar_i2c_priv *priv)
}
dma_addr = dma_map_single(chan->device->dev, buf, len, dir);
- if (dma_mapping_error(dev, dma_addr)) {
+ if (dma_mapping_error(chan->device->dev, dma_addr)) {
dev_dbg(dev, "dma map failed, using PIO\n");
return;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] i2c: rcar: use proper device with dma_mapping_error
2016-08-24 9:19 ` [PATCH 2/2] i2c: rcar: " Wolfram Sang
@ 2016-08-25 7:59 ` Geert Uytterhoeven
2016-08-25 16:50 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-08-25 7:59 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Linux I2C, Linux-Renesas, Niklas Söderlund
On Wed, Aug 24, 2016 at 11:19 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We must use the same device we used for mapping.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] i2c: rcar: use proper device with dma_mapping_error
2016-08-24 9:19 ` [PATCH 2/2] i2c: rcar: " Wolfram Sang
2016-08-25 7:59 ` Geert Uytterhoeven
@ 2016-08-25 16:50 ` Wolfram Sang
1 sibling, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-08-25 16:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, linux-renesas-soc, Geert Uytterhoeven,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
On Wed, Aug 24, 2016 at 11:19:29AM +0200, Wolfram Sang wrote:
> We must use the same device we used for mapping.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error
2016-08-24 9:19 [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error Wolfram Sang
2016-08-24 9:19 ` [PATCH 2/2] i2c: rcar: " Wolfram Sang
@ 2016-08-25 7:59 ` Geert Uytterhoeven
2016-08-25 16:50 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-08-25 7:59 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Linux I2C, Linux-Renesas, Niklas Söderlund
On Wed, Aug 24, 2016 at 11:19 AM, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> We must use the same device we used for mapping.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error
2016-08-24 9:19 [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error Wolfram Sang
2016-08-24 9:19 ` [PATCH 2/2] i2c: rcar: " Wolfram Sang
2016-08-25 7:59 ` [PATCH 1/2] i2c: sh_mobile: " Geert Uytterhoeven
@ 2016-08-25 16:50 ` Wolfram Sang
2 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2016-08-25 16:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, linux-renesas-soc, Geert Uytterhoeven,
Niklas Söderlund
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
On Wed, Aug 24, 2016 at 11:19:28AM +0200, Wolfram Sang wrote:
> We must use the same device we used for mapping.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-25 16:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-24 9:19 [PATCH 1/2] i2c: sh_mobile: use proper device with dma_mapping_error Wolfram Sang
2016-08-24 9:19 ` [PATCH 2/2] i2c: rcar: " Wolfram Sang
2016-08-25 7:59 ` Geert Uytterhoeven
2016-08-25 16:50 ` Wolfram Sang
2016-08-25 7:59 ` [PATCH 1/2] i2c: sh_mobile: " Geert Uytterhoeven
2016-08-25 16:50 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).