From: Wolfram Sang <wsa@the-dreams.de>
To: Jan Glauber <jglauber@cavium.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH v11 0/8] i2c-octeon and i2c-thunderx driver
Date: Thu, 25 Aug 2016 18:37:09 +0200 [thread overview]
Message-ID: <20160825163709.GG2856@katana> (raw)
In-Reply-To: <20160824212549.16140-1-jglauber@cavium.com>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Wed, Aug 24, 2016 at 11:25:41PM +0200, Jan Glauber wrote:
> Hi Wolfram,
>
> this update should address all comments. The probe funtion
> is much easier to read now after using the managed device functions.
>
> We also had an issue with the 5ms timeout and some ipmi/ssif commands so
> I dropped the timeout setting to get the 1s default.
>
> Changes to v10:
> - Proper use of managed device functions
> - Renamed files
> - Removed i2c class setting
> - Droped timeout setting
> - Improved Kconfig dependency
> - Removed most probing kernel messages
> - select SMBUS instead of if-defing
> - Removed bogus i2c pointer check
> - Explicitely mention GPL version
> - Drop whitespace fixes from MAINTAINERS patch
Yay, looks much better now IMO.
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-25 16:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 21:25 [PATCH v11 0/8] i2c-octeon and i2c-thunderx driver Jan Glauber
2016-08-24 21:25 ` [PATCH v11 1/8] i2c: octeon: Rename driver to prepare for split Jan Glauber
2016-08-24 21:25 ` [PATCH v11 2/8] i2c: octeon: Split the driver into two parts Jan Glauber
2016-08-24 21:25 ` [PATCH v11 3/8] i2c: thunderx: Add i2c driver for ThunderX SOC Jan Glauber
2016-08-24 21:25 ` [PATCH v11 4/8] i2c: thunderx: Add SMBUS alert support Jan Glauber
2016-08-24 21:25 ` [PATCH v11 5/8] i2c: octeon,thunderx: Move register offsets to struct Jan Glauber
2016-08-24 21:25 ` [PATCH v11 6/8] i2c: octeon: Sort include files alphabetically Jan Glauber
2016-08-24 21:25 ` [PATCH v11 7/8] i2c: octeon: Use booleon values for booleon variables Jan Glauber
2016-08-24 21:25 ` [PATCH v11 8/8] i2c: octeon: thunderx: Add MAINTAINERS entry Jan Glauber
2016-08-25 16:37 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825163709.GG2856@katana \
--to=wsa@the-dreams.de \
--cc=ddaney@caviumnetworks.com \
--cc=jglauber@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).