linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Shardar Mohammed <smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Laxman Dewangan
	<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	"swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org"
	<swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
	"thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed
Date: Thu, 25 Aug 2016 21:39:53 +0200	[thread overview]
Message-ID: <20160825193952.GC1614@katana> (raw)
In-Reply-To: <6d21b4bd199844e3a359cc52823045db-7W72rfoJkVlxWE4FnwvcdlaTQe2KTcn/@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]


> > > +		err = readx_poll_timeout(readl, i2c_dev->base + reg_offset,
> > > +					 val, val == 0, 1000,
> > > +					 I2C_CONFIG_LOAD_TIMEOUT);
> > 
> > Any reason we can't use readl_poll_timeout() here?
> [Shardar] Can be used, will change and push the new patchset.

Still interested? Should be an easy change, but I am reluctant to fix it
here with no testing.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-08-25 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27 13:37 [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed Shardar Shariff Md
2016-05-27 13:37 ` [PATCH v8 2/3] i2c: tegra: add separate function for config_load programing Shardar Shariff Md
2016-05-27 13:37 ` [PATCH v8 3/3] i2c: tegra: proper handling of error cases Shardar Shariff Md
     [not found] ` <1464356224-10339-1-git-send-email-smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-06-19 17:21   ` [PATCH v8 1/3] i2c: tegra: use readx_poll_timeout after config_load reg programmed Wolfram Sang
2016-06-19 18:21     ` Shardar Mohammed
     [not found]       ` <6d21b4bd199844e3a359cc52823045db-7W72rfoJkVlxWE4FnwvcdlaTQe2KTcn/@public.gmane.org>
2016-08-25 19:39         ` Wolfram Sang [this message]
2016-08-26  9:19           ` Shardar Mohammed
     [not found]             ` <362fc8af7f8d411c8af36b34c6165c1b-7W72rfoJkVlxWE4FnwvcdlaTQe2KTcn/@public.gmane.org>
2016-08-26 15:53               ` Wolfram Sang
2016-08-30 19:16                 ` Shardar Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160825193952.GC1614@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smohammed-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).