From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/6] i2c: tegra: Add runtime power-management support
Date: Fri, 26 Aug 2016 00:31:31 +0200 [thread overview]
Message-ID: <20160825223130.GA1621@katana> (raw)
In-Reply-To: <c546ae53-005e-83d7-136d-d12a83b58549-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
> > You could have left the original 'return' instead of the 2 new ones, but
> > you decide.
>
> Yes I know, but I wanted to ensure for runtime-pm we only return 0 on
> success. Yes clk_enable should only return 0 on success and a negative
> error code otherwise, but I prefer this. So will leave as-is.
OK.
>
> >> - if (tegra_i2c_flush_fifos(i2c_dev))
> >> - err = -ETIMEDOUT;
> >> + err = tegra_i2c_flush_fifos(i2c_dev);
> >
> > 'err' is assigned but where is it checked?
>
> It will be returned by the function. This is no different to how it
> works today if you look at the code. I did think about checking it right
I agree. I missed it before, thanks for the heads up.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-25 22:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 10:16 [PATCH 0/6] Some Tegra I2C Updates Jon Hunter
2016-08-11 10:16 ` [PATCH 1/6] i2c: tegra: Add missing new line characters Jon Hunter
[not found] ` <1470910620-9898-2-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-11 14:58 ` Laxman Dewangan
2016-08-11 10:16 ` [PATCH 2/6] i2c: tegra: Remove non device-tree support Jon Hunter
2016-08-11 14:59 ` Laxman Dewangan
[not found] ` <1470910620-9898-3-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-25 19:33 ` Wolfram Sang
2016-08-25 20:49 ` Jon Hunter
2016-08-11 10:16 ` [PATCH 3/6] i2c: tegra: Use device name for adapter name Jon Hunter
2016-08-11 14:59 ` Laxman Dewangan
2016-08-11 10:16 ` [PATCH 4/6] i2c: tegra: Simplify I2C resume Jon Hunter
[not found] ` <1470910620-9898-5-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-11 15:00 ` Laxman Dewangan
2016-08-11 10:16 ` [PATCH 5/6] i2c: tegra: Add runtime power-management support Jon Hunter
[not found] ` <1470910620-9898-6-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-11 15:01 ` Laxman Dewangan
2016-08-25 19:26 ` Wolfram Sang
2016-08-25 20:53 ` Jon Hunter
[not found] ` <c546ae53-005e-83d7-136d-d12a83b58549-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-25 22:31 ` Wolfram Sang [this message]
2016-08-11 10:17 ` [PATCH 6/6] i2c: tegra: Add pinctrl support Jon Hunter
[not found] ` <1470910620-9898-7-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-11 15:01 ` Laxman Dewangan
[not found] ` <1470910620-9898-1-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-08-24 11:10 ` [PATCH 0/6] Some Tegra I2C Updates Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825223130.GA1621@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).