linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
	"David E. Box" <david.e.box@linux.intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2] i2c: designware-baytrail: Fix the Kconfig dependency fix
Date: Fri, 26 Aug 2016 17:40:41 +0200	[thread overview]
Message-ID: <20160826174041.720d29bb@endymion> (raw)
In-Reply-To: <20160825202425.GH1614@katana>

Hi Wolfram, Jarkko,

On Thu, 25 Aug 2016 22:24:25 +0200, Wolfram Sang wrote:
> On Fri, Jul 22, 2016 at 10:24:03AM +0200, Jean Delvare wrote:
> > Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for
> > proper Kconfig dependencies") claims that the "Baytrail driver" isn't
> > tristate. But in fact there is no such thing as a "Baytrail driver",
> > i2c-designware-baytrail is not a stand-alone driver but an optional
> > addition to the i2c-designware-platform driver, and that driver *is*
> > tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't
> > be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.
> > 
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Fixes: b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies")
> > Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Cc: David E. Box <david.e.box@linux.intel.com>
> > Cc: Wolfram Sang <wsa@the-dreams.de>
> 
> I applied a patch from Jarkko on 19.6.2016 which also changed the
> dependencies. Not sure if it is equal to your change, but this patch
> doesn't apply anymore.

As I understand it, Jarkko's patch sets the same dependencies my patch
was setting, just expressed differently. So we are good, you can drop
my patch.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2016-08-26 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22  8:24 [PATCH v2] i2c: designware-baytrail: Fix the Kconfig dependency fix Jean Delvare
2016-08-25 20:24 ` Wolfram Sang
2016-08-26 15:40   ` Jean Delvare [this message]
2016-08-26 15:46     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160826174041.720d29bb@endymion \
    --to=jdelvare@suse.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=david.e.box@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rdunlap@infradead.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).