From: Wolfram Sang <wsa@the-dreams.de>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Nicolai Stange <nicstange@gmail.com>,
Octavian Purdila <octavian.purdila@intel.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter
Date: Wed, 21 Sep 2016 07:48:35 +0200 [thread overview]
Message-ID: <20160921054834.GC1484@katana> (raw)
In-Reply-To: <20160920135925.45450-1-mika.westerberg@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]
On Tue, Sep 20, 2016 at 04:59:25PM +0300, Mika Westerberg wrote:
> When enumerating I2C devices connected to an I2C adapter we scan the whole
> namespace (as it is possible to have devices anywhere in that namespace,
> not just below the I2C adapter device) and add each found device to the I2C
> bus in question.
>
> Now after commit 525e6fabeae2 ("i2c / ACPI: add support for ACPI
> reconfigure notifications") checking of the adapter handle to the one found
> in the I2cSerialBus() resource was moved to happen after resources of the
> I2C device has been parsed. This means that if the I2cSerialBus() resource
> points to an adapter that does not exists in the system we still parse
> those resources. This is problematic in particular because
> acpi_dev_resource_interrupt() tries to configure GSI if the device also has
> an Interrupt() resource. Failing to do that results errrors like this to be
> printed on the console:
>
> [ 10.409490] ERROR: Unable to locate IOAPIC for GSI 37
>
> To fix this we pass the I2C adapter to i2c_acpi_get_info() and make sure
> the handle matches the one in the I2cSerialBus() resource before doing
> anything else to the device.
>
> Reported-and-tested-by: Nicolai Stange <nicstange@gmail.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Considering this for for-current. So shall we add:
Fixes: 525e6fabeae2 ("i2c / ACPI: add support for ACPI reconfigure notifications")
?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-21 5:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87a8f4kfhe.fsf@gmail.com>
2016-09-19 8:48 ` [REGRESSION? v4.8] i2c-core: acpi_i2c_get_info() touches non-existent devices Mika Westerberg
2016-09-19 13:03 ` Mika Westerberg
2016-09-19 13:58 ` Nicolai Stange
2016-09-20 7:55 ` Mika Westerberg
2016-09-20 8:00 ` [PATCH] i2c / ACPI: Do not touch an I2C device if it belongs to another adapter Mika Westerberg
2016-09-20 10:32 ` Nicolai Stange
2016-09-20 10:45 ` Mika Westerberg
2016-09-20 13:59 ` [PATCH v2] " Mika Westerberg
2016-09-20 18:49 ` Nicolai Stange
2016-09-21 5:48 ` Wolfram Sang [this message]
2016-09-21 8:45 ` Mika Westerberg
2016-09-21 16:14 ` Wolfram Sang
2016-09-22 8:49 ` Mika Westerberg
2016-09-22 8:59 ` Wolfram Sang
2016-09-22 9:25 ` Mika Westerberg
2016-09-22 17:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921054834.GC1484@katana \
--to=wsa@the-dreams.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nicstange@gmail.com \
--cc=octavian.purdila@intel.com \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).