linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Yadi Hu <yadi.hu@windriver.com>
Cc: jdelvare@suse.de, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c-eg20t: fix race between i2c init and interrupt enable
Date: Wed, 21 Sep 2016 18:18:47 +0200	[thread overview]
Message-ID: <20160921161846.GC1432@katana> (raw)
In-Reply-To: <20160921161608.GB1432@katana>

[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]

On Wed, Sep 21, 2016 at 06:16:09PM +0200, Wolfram Sang wrote:
> On Sun, Sep 18, 2016 at 06:52:31PM +0800, Yadi Hu wrote:
> > From: "Yadi.hu" <yadi.hu@windriver.com>
> > 
> > the eg20t driver call request_irq() function before the pch_base_address,
> > base address of i2c controller's register, is assigned an effective value.
> > 
> > there is one possible scenario that an interrupt which isn't inside eg20t
> > arrives immediately after request_irq() is executed when i2c controller
> > shares an interrupt number with others. since the interrupt handler
> > pch_i2c_handler() has already active as shared action, it will be called
> > and read its own register to determine if this interrupt is from itself.
> > 
> > At that moment, since base address of i2c registers is not remapped
> > in kernel space yet,so the INT handler will access an illegal address
> > and then a error occurs.
> > 
> > Signed-off-by: Yadi.hu <yadi.hu@windriver.com>
> 
> Applied to for-next, thanks!

I meant: applied to for-current!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-09-21 17:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-18 10:52 RESEND: V3 i2c-eg20t:fix race between i2c init and interrupt enable Yadi Hu
2016-09-18 10:52 ` [PATCH] i2c-eg20t: fix " Yadi Hu
2016-09-21 16:16   ` Wolfram Sang
2016-09-21 16:18     ` Wolfram Sang [this message]
2016-09-22  1:19       ` Yadi
2016-09-22  1:04     ` Yadi
2016-09-22  6:02       ` Wolfram Sang
  -- strict thread matches above, loose matches on Subject: below --
2016-09-07  9:25 RESEND:i2c-eg20t: " Yadi Hu
2016-09-07  9:25 ` [PATCH] i2c-eg20t: " Yadi Hu
2016-08-29  2:56 Yadi Hu
2016-09-02 10:05 ` Yadi
2016-08-23  9:07 Yadi Hu
2016-08-26 15:32 ` Jean Delvare
2016-08-29  3:02   ` Yadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160921161846.GC1432@katana \
    --to=wsa@the-dreams.de \
    --cc=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=yadi.hu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).