From: Wolfram Sang <wsa@the-dreams.de>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>
Subject: Re: [PATCH] i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended
Date: Thu, 22 Sep 2016 20:09:28 +0200 [thread overview]
Message-ID: <20160922180928.GG1861@katana> (raw)
In-Reply-To: <1472124219-1627-1-git-send-email-sudeep.holla@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1529 bytes --]
On Thu, Aug 25, 2016 at 12:23:39PM +0100, Sudeep Holla wrote:
> If the i2c device is already runtime suspended, if qup_i2c_suspend is
> executed during suspend-to-idle or suspend-to-ram it will result in the
> following splat:
>
> WARNING: CPU: 3 PID: 1593 at drivers/clk/clk.c:476 clk_core_unprepare+0x80/0x90
> Modules linked in:
>
> CPU: 3 PID: 1593 Comm: bash Tainted: G W 4.8.0-rc3 #14
> Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT)
> PC is at clk_core_unprepare+0x80/0x90
> LR is at clk_unprepare+0x28/0x40
> pc : [<ffff0000086eecf0>] lr : [<ffff0000086f0c58>] pstate: 60000145
> Call trace:
> clk_core_unprepare+0x80/0x90
> qup_i2c_disable_clocks+0x2c/0x68
> qup_i2c_suspend+0x10/0x20
> platform_pm_suspend+0x24/0x68
> dpm_run_callback.isra.7+0x1c/0x70
> __device_suspend+0xf4/0x298
> dpm_suspend+0x10c/0x228
> dpm_suspend_start+0x68/0x78
> suspend_devices_and_enter+0xb8/0x460
> pm_suspend+0x1ec/0x240
> state_store+0x84/0xf8
> kobj_attr_store+0x14/0x28
> sysfs_kf_write+0x48/0x58
> kernfs_fop_write+0x15c/0x1f8
> __vfs_write+0x1c/0x100
> vfs_write+0x9c/0x1b8
> SyS_write+0x44/0xa0
> el0_svc_naked+0x24/0x28
>
> This patch fixes the issue by executing qup_i2c_pm_suspend_runtime
> conditionally in qup_i2c_suspend.
>
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-09-22 18:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 11:23 [PATCH] i2c: qup: skip qup_i2c_suspend if the device is already runtime suspended Sudeep Holla
2016-09-13 12:38 ` Sudeep Holla
2016-09-14 17:33 ` Andy Gross
2016-09-22 18:10 ` Wolfram Sang
2016-09-22 18:09 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922180928.GG1861@katana \
--to=wsa@the-dreams.de \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).