From: Jean Delvare <jdelvare@suse.de>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de
Subject: Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks
Date: Thu, 13 Oct 2016 13:30:52 +0200 [thread overview]
Message-ID: <20161013133052.3e2296d1@endymion> (raw)
In-Reply-To: <20161011172441.7422-4-palminha@synopsys.com>
Hi Carlos,
On Tue, 11 Oct 2016 18:24:39 +0100, Carlos Palminha wrote:
> Signed-off-by: Carlos Palminha <palminha@synopsys.com>
> ---
> drivers/i2c/busses/i2c-piix4.c | 94 ++++++++++++++++++++++++------------------
> 1 file changed, 54 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 5d6f637..85b1052 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> (...)
> /*
> - Supports:
> - Intel PIIX4, 440MX
> - Serverworks OSB4, CSB5, CSB6, HT-1000, HT-1100
> - ATI IXP200, IXP300, IXP400, SB600, SB700/SP5100, SB800
> - AMD Hudson-2, ML, CZ
> - SMSC Victory66
> -
> - Note: we assume there can only be one device, with one or more
> - SMBus interfaces.
> - The device can register multiple i2c_adapters (up to PIIX4_MAX_ADAPTERS).
> - For devices supporting multiple ports the i2c_adapter should provide
> - an i2c_algorithm to access them.
> -*/
> + * Supports:
> + * Intel PIIX4, 440MX
> + * Serverworks OSB4, CSB5, CSB6, HT-1000, HT-1100
> + * ATI IXP200, IXP300, IXP400, SB600, SB700/SP5100, SB800
> + * AMD Hudson-2, ML, CZ
> + * SMSC Victory66
> + *
> + * Note: we assume there can only be one device, with one or more
There's an extra space before "Note:", please remove.
> + * SMBus interfaces.
> + * The device can register multiple i2c_adapters (up to PIIX4_MAX_ADAPTERS).
> + * For devices supporting multiple ports the i2c_adapter should provide
> + * an i2c_algorithm to access them.
> + */
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-10-13 11:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 17:24 [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Carlos Palminha
2016-10-11 17:24 ` [PATCH 1/5] i2c: i2c-piix4: coding style fix - '*' adjacent to data name Carlos Palminha
2016-10-11 17:24 ` [PATCH 2/5] i2c: i2c-piix4: coding style fix - assignment in if condition Carlos Palminha
2016-10-11 17:24 ` [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks Carlos Palminha
2016-10-13 11:30 ` Jean Delvare [this message]
2016-10-11 17:24 ` [PATCH 4/5] i2c: i2c-piix4: coding style fix - spaces with open parenthesis Carlos Palminha
2016-10-11 17:34 ` [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string split across lines Carlos Palminha
2016-10-12 2:03 ` Joe Perches
2016-10-13 11:34 ` Jean Delvare
2016-10-13 11:40 ` [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Jean Delvare
2016-10-13 16:44 ` Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013133052.3e2296d1@endymion \
--to=jdelvare@suse.de \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).