From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading Date: Mon, 24 Oct 2016 11:09:38 +0100 Message-ID: <20161024100938.GI14477@dell> References: <20161005155112.13774-1-hdegoede@redhat.com> <20161005155112.13774-2-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f54.google.com ([74.125.82.54]:35038 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752395AbcJXKHH (ORCPT ); Mon, 24 Oct 2016 06:07:07 -0400 Received: by mail-wm0-f54.google.com with SMTP id c78so95069952wme.0 for ; Mon, 24 Oct 2016 03:07:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Hans de Goede Cc: Chen-Yu Tsai , Sebastian Reichel , Dennis Gilmore , Maxime Ripard , "open list:THERMAL" , linux-arm-kernel , Wolfram Sang , linux-i2c@vger.kernel.org On Tue, 18 Oct 2016, Hans de Goede wrote: > On 18-10-16 07:25, Chen-Yu Tsai wrote: > > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede wrote: > > > The i2c subsys does not load modules by compatible, only by > > > i2c-id, with e.g. a modalias of: "i2c:axp209". > > > > > > Populate the axp20x_i2c_id[] table with supported ids, so that > > > module auto-loading will work. > > > > > > Reported-by: Dennis Gilmore > > > Signed-off-by: Hans de Goede > > > > Acked-by: Chen-Yu Tsai > > > > Even though axp20x-i2c seems to be the only "DT only" i2c client, > > would it make sense to add DT-based module autoloading to the i2c > > core? > > If it is not too invasive, then yes that would be a sensible addition IMHO. If I understand you correctly, I already have a patch-set on the ML that does this. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog