From: Wolfram Sang <wsa@the-dreams.de>
To: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
Cc: Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linux SPI <linux-spi@vger.kernel.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
"linux-kernel @ vger . kernel . org"
<linux-kernel@vger.kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Subject: Re: [PATCH v2 2/2] i2c: mark device nodes only in case of successful instantiation
Date: Tue, 25 Oct 2016 11:23:01 +0200 [thread overview]
Message-ID: <20161025092301.GC1597@katana> (raw)
In-Reply-To: <20161017135957.20297-3-ralf@ramses-pyramidenbau.de>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
On Mon, Oct 17, 2016 at 03:59:57PM +0200, Ralf Ramsauer wrote:
> Instantiated I2C device nodes are marked with OF_POPULATE. This was
> introduced in 4f001fd. On unloading, loaded device nodes will of course
> be unmarked. The problem are nodes that fail during initialisation: If a
> node fails, it won't be unloaded and hence not be unmarked.
>
> If a I2C driver module is unloaded and reloaded, it will skip nodes that
> failed before.
>
> Skip device nodes that are already populated and mark them only in case
> of success.
>
> Note that the same issue exists for SPI.
>
> Fixes: 4f001fd ("i2c: Mark instantiated device nodes with OF_POPULATE")
> Signed-off-by: Ralf Ramsauer <ralf@ramses-pyramidenbau.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-25 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 13:59 [PATCH v2 0/2] spi, i2c: mark device nodes only in case of successful instantiation Ralf Ramsauer
2016-10-17 13:59 ` [PATCH v2 1/2] spi: " Ralf Ramsauer
2016-10-17 14:15 ` Geert Uytterhoeven
[not found] ` <20161017135957.20297-2-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-10-17 19:16 ` Pantelis Antoniou
2016-10-24 17:30 ` Mark Brown
2016-10-24 18:05 ` Applied "spi: mark device nodes only in case of successful instantiation" to the spi tree Mark Brown
2016-10-17 13:59 ` [PATCH v2 2/2] i2c: mark device nodes only in case of successful instantiation Ralf Ramsauer
2016-10-17 14:16 ` Geert Uytterhoeven
2016-10-17 14:37 ` Ralf Ramsauer
2016-10-17 19:16 ` Pantelis Antoniou
2016-10-25 9:23 ` Wolfram Sang [this message]
[not found] ` <20161017135957.20297-1-ralf-ex4EvEgDZR1o7HI0AxOeTKwczVv4G7md@public.gmane.org>
2016-10-17 19:15 ` [PATCH v2 0/2] spi, " Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025092301.GC1597@katana \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=ralf@ramses-pyramidenbau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).