From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Tin Huynh <tnhuynh@apm.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Loc Ho <lho@apm.com>, Thang Nguyen <tqnguyen@apm.com>,
Phong Vo <pvo@apm.com>, patches <patches@apm.com>
Subject: Re: [PATCH v1] I2C Designware Core Supports SMBUS BLOCK
Date: Wed, 26 Oct 2016 12:30:34 +0300 [thread overview]
Message-ID: <20161026093034.GO1476@lahna.fi.intel.com> (raw)
In-Reply-To: <CANQ9TuAgW7ubyKq1RAiw+s=ooF4G99_MMWnG1a0bV3DxKa+UPw@mail.gmail.com>
On Wed, Oct 26, 2016 at 04:20:57PM +0700, Tin Huynh wrote:
> We need to set stop bit if three conditions are true : The latest
> bytes , the latest msg_write_ids and after receiving the buffer length.
> If we use i2c_dw_xfer_need_stop , arguments of function are complex.
OK, so you would need to pass dev and buf_len to that.
> Can i use i2c_dw_xfer_receive_length() function ?
> Thank you and best regards
> Tin
> if (dev->msg_write_idx == dev->msgs_num - 1 &&
> - buf_len == 1)
> + buf_len == 1 && !(flags & I2C_M_RECV_LEN))
> cmd |= BIT(9);
Maybe it is better if you just do it like the above then.
prev parent reply other threads:[~2016-10-26 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 4:35 [PATCH v1] I2C Designware Core Supports SMBUS BLOCK tnhuynh
2016-10-25 7:58 ` Jarkko Nikula
2016-10-25 11:50 ` Mika Westerberg
2016-10-25 12:34 ` Andy Shevchenko
[not found] ` <CANQ9TuB5BbR40TEndGqQ6ABDSUsCOGjEhXSvmD78jtuqGRpXvg@mail.gmail.com>
2016-10-26 8:16 ` Mika Westerberg
[not found] ` <CANQ9TuAgW7ubyKq1RAiw+s=ooF4G99_MMWnG1a0bV3DxKa+UPw@mail.gmail.com>
2016-10-26 9:30 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026093034.GO1476@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lho@apm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=tnhuynh@apm.com \
--cc=tqnguyen@apm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).