From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Subject: Re: [PATCH v4 07/14] ARM: dts: koelsch: use demuxer for I2C4
Date: Wed, 16 Nov 2016 15:17:14 +0100 [thread overview]
Message-ID: <20161116141713.GA25812@verge.net.au> (raw)
In-Reply-To: <CAMuHMdXsUA+OywpfuNwunuCSupczKSuWnAgs3Zdq7zMxrD6OWQ@mail.gmail.com>
On Wed, Nov 16, 2016 at 03:14:11PM +0100, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Wed, Nov 16, 2016 at 2:47 PM, Simon Horman <horms@verge.net.au> wrote:
> > On Wed, Nov 16, 2016 at 11:35:22AM +0100, Geert Uytterhoeven wrote:
> >> On Tue, Nov 15, 2016 at 6:44 PM, Simon Horman <horms@verge.net.au> wrote:
> >> >> i2c4 shares pins with vin0. Hence enabling the former breaks the latter:
> >> >>
> >> >> sh-pfc e6060000.pfc: pin GP_4_13 already requested by
> >> >> e6520000.i2c; cannot claim for e6ef0000.video
> >> >> sh-pfc e6060000.pfc: pin-141 (e6ef0000.video) status -22
> >> >> sh-pfc e6060000.pfc: could not request pin 141 (GP_4_13) from
> >> >> group vin0_data24 on device sh-pfc
> >> >> rcar-vin e6ef0000.video: Error applying setting, reverse things back
> >> >> rcar-vin: probe of e6ef0000.video failed with error -22
> >> >>
> >> >> There may be similar issues on other boards. Haven't checked yet.
> >> >
> >> > Thanks, I will drop this patch for now.
> >> >
> >> > I checked the boot logs of other boards with similar patches and didn't see
> >> > anything there.
> >>
> >> Do you have CONFIG_VIDEO_ADV7604=y?
> >
> > No, mainly because its not in shmobile_defconfig.
> >
> > I tried again with that option enabled and still didn't see
> > anything of interest in kernel log.
> >
> >> I expect the issue to be present on gose, too. So far I didn't see it
> >> there, yet.
> >> But the vin DTS of gose is different from koelsch, causing vin0 not to be
> >> initialized?
> >
> > It seems so.
>
> I managed to reproduce the issue on gose, by adding r8a7793 support to
> my koelsch .config.
> Apparently I was missing CONFIG_I2C_DEMUX_PINCTRL=y.
Ok, thanks. Curious that I didn't see it.
It looks like we should drop:
ARM: dts: gose: use demuxer for I2C4
next prev parent reply other threads:[~2016-11-16 14:17 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-06 20:20 [PATCH v4 00/14] ARM: dts: r8a779x: use demuxer for I2C Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 01/14] ARM: dts: lager: rename and reindex i2cexio Wolfram Sang
2016-11-07 13:12 ` Geert Uytterhoeven
2016-11-10 10:11 ` Simon Horman
2016-11-06 20:20 ` [PATCH v4 02/14] ARM: dts: lager: use demuxer for IIC1/I2C1 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 03/14] ARM: dts: lager: use demuxer for IIC2/I2C2 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 04/14] ARM: dts: lager: use demuxer for IIC3/I2C3 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 05/14] ARM: dts: koelsch: use demuxer for I2C1 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 06/14] ARM: dts: koelsch: use demuxer for I2C2 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 07/14] ARM: dts: koelsch: use demuxer for I2C4 Wolfram Sang
2016-11-15 15:45 ` Geert Uytterhoeven
2016-11-15 17:44 ` Simon Horman
2016-11-16 10:35 ` Geert Uytterhoeven
2016-11-16 13:47 ` Simon Horman
2016-11-16 14:14 ` Geert Uytterhoeven
2016-11-16 14:17 ` Simon Horman [this message]
2016-11-16 13:48 ` Geert Uytterhoeven
2016-11-06 20:20 ` [PATCH v4 08/14] ARM: dts: porter: use demuxer for I2C2 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 09/14] ARM: dts: gose: " Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 10/14] ARM: dts: gose: use demuxer for I2C4 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 11/14] ARM: dts: alt: use demuxer for I2C1 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 12/14] ARM: dts: alt: use demuxer for I2C4 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 13/14] ARM: dts: silk: use demuxer for I2C1 Wolfram Sang
2016-11-06 20:20 ` [PATCH v4 14/14] i2c: mux: demux-pinctrl: make drivers with no pinctrl work again Wolfram Sang
2016-11-07 13:10 ` Geert Uytterhoeven
2016-11-10 20:12 ` Wolfram Sang
2016-11-09 8:44 ` [PATCH v4 00/14] ARM: dts: r8a779x: use demuxer for I2C Simon Horman
2016-11-09 8:55 ` Geert Uytterhoeven
2016-11-09 8:59 ` Wolfram Sang
2016-11-09 14:35 ` Simon Horman
2016-11-09 19:00 ` Geert Uytterhoeven
2016-11-11 8:20 ` Simon Horman
2016-11-10 10:06 ` Simon Horman
2016-11-09 17:28 ` Wolfram Sang
2016-11-10 3:56 ` Magnus Damm
2016-11-10 7:57 ` Wolfram Sang
2016-11-10 8:12 ` Magnus Damm
2016-11-10 15:30 ` Niklas Söderlund
2016-11-10 15:39 ` Wolfram Sang
2017-01-04 10:25 ` Wolfram Sang
2017-01-09 9:34 ` Niklas Söderlund
2017-01-31 15:42 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161116141713.GA25812@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulrich.hecht+renesas@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).