* i2c: xlp9xx: ACPI support for I2C clients
@ 2016-09-15 19:27 Tanmay Jagdale
2016-09-21 21:17 ` Wolfram Sang
2016-11-18 1:27 ` Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Tanmay Jagdale @ 2016-09-15 19:27 UTC (permalink / raw)
To: wsa; +Cc: linux-i2c, jayachandran.chandrashekaran, Tanmay Jagdale
The ACPI companion of the adapter has to be set for I2C controller
code to read and attach the slave devices described in the ACPI table
with the I2CSerialBus resource descriptor. Used ACPI_COMPANION_SET
macro to set this.
Signed-off-by: Tanmay Jagdale <tanmay.jagdale@broadcom.com>
---
drivers/i2c/busses/i2c-xlp9xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
index 55a7bef..916f192 100644
--- a/drivers/i2c/busses/i2c-xlp9xx.c
+++ b/drivers/i2c/busses/i2c-xlp9xx.c
@@ -393,6 +393,7 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev)
init_completion(&priv->msg_complete);
priv->adapter.dev.parent = &pdev->dev;
priv->adapter.algo = &xlp9xx_i2c_algo;
+ ACPI_COMPANION_SET(&(priv->adapter.dev), ACPI_COMPANION(&pdev->dev));
priv->adapter.dev.of_node = pdev->dev.of_node;
priv->dev = &pdev->dev;
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: i2c: xlp9xx: ACPI support for I2C clients
2016-09-15 19:27 i2c: xlp9xx: ACPI support for I2C clients Tanmay Jagdale
@ 2016-09-21 21:17 ` Wolfram Sang
2016-09-26 10:43 ` [PATCH v2] " Tanmay Jagdale
2016-11-18 1:27 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2016-09-21 21:17 UTC (permalink / raw)
To: Tanmay Jagdale; +Cc: linux-i2c, jayachandran.chandrashekaran
[-- Attachment #1: Type: text/plain, Size: 124 bytes --]
> + ACPI_COMPANION_SET(&(priv->adapter.dev), ACPI_COMPANION(&pdev->dev));
No need for parenthesis in the first argument.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] i2c: xlp9xx: ACPI support for I2C clients
2016-09-21 21:17 ` Wolfram Sang
@ 2016-09-26 10:43 ` Tanmay Jagdale
2016-11-19 21:10 ` [v2] " Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Tanmay Jagdale @ 2016-09-26 10:43 UTC (permalink / raw)
To: wsa; +Cc: linux-i2c, jayachandran.chandrashekaran, Tanmay Jagdale
The ACPI companion of the adapter has to be set for I2C controller
code to read and attach the slave devices described in the ACPI table
with the I2CSerialBus resource descriptor. Used ACPI_COMPANION_SET
macro to set this.
Signed-off-by: Tanmay Jagdale <tanmay.jagdale@broadcom.com>
---
Changes in v2
- Fixed parenthesis
drivers/i2c/busses/i2c-xlp9xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
index 55a7bef..10e47dd 100644
--- a/drivers/i2c/busses/i2c-xlp9xx.c
+++ b/drivers/i2c/busses/i2c-xlp9xx.c
@@ -393,6 +393,7 @@ static int xlp9xx_i2c_probe(struct platform_device *pdev)
init_completion(&priv->msg_complete);
priv->adapter.dev.parent = &pdev->dev;
priv->adapter.algo = &xlp9xx_i2c_algo;
+ ACPI_COMPANION_SET(&priv->adapter.dev, ACPI_COMPANION(&pdev->dev));
priv->adapter.dev.of_node = pdev->dev.of_node;
priv->dev = &pdev->dev;
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [v2] i2c: xlp9xx: ACPI support for I2C clients
2016-09-26 10:43 ` [PATCH v2] " Tanmay Jagdale
@ 2016-11-19 21:10 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-11-19 21:10 UTC (permalink / raw)
To: Tanmay Jagdale; +Cc: wsa, linux-i2c, jayachandran.chandrashekaran
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
On Mon, Sep 26, 2016 at 04:13:03PM +0530, Tanmay Jagdale wrote:
> The ACPI companion of the adapter has to be set for I2C controller
> code to read and attach the slave devices described in the ACPI table
> with the I2CSerialBus resource descriptor. Used ACPI_COMPANION_SET
> macro to set this.
>
> Signed-off-by: Tanmay Jagdale <tanmay.jagdale@broadcom.com>
So, you did resend the patch and I missed it. Please ignore what I wrote
in the last mail. Thanks for resending properly and again sorry for
overlooking this patch.
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: i2c: xlp9xx: ACPI support for I2C clients
2016-09-15 19:27 i2c: xlp9xx: ACPI support for I2C clients Tanmay Jagdale
2016-09-21 21:17 ` Wolfram Sang
@ 2016-11-18 1:27 ` Wolfram Sang
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2016-11-18 1:27 UTC (permalink / raw)
To: Tanmay Jagdale; +Cc: wsa, linux-i2c, jayachandran.chandrashekaran
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Fri, Sep 16, 2016 at 12:57:39AM +0530, Tanmay Jagdale wrote:
> The ACPI companion of the adapter has to be set for I2C controller
> code to read and attach the slave devices described in the ACPI table
> with the I2CSerialBus resource descriptor. Used ACPI_COMPANION_SET
> macro to set this.
>
> Signed-off-by: Tanmay Jagdale <tanmay.jagdale@broadcom.com>
Applied to for-next, but please fix review comments yourself next time.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-19 21:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15 19:27 i2c: xlp9xx: ACPI support for I2C clients Tanmay Jagdale
2016-09-21 21:17 ` Wolfram Sang
2016-09-26 10:43 ` [PATCH v2] " Tanmay Jagdale
2016-11-19 21:10 ` [v2] " Wolfram Sang
2016-11-18 1:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).