From: Wolfram Sang <wsa-dev@sang-engineering.com>
To: vadimp@mellanox.com
Cc: wsa@the-dreams.de, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, jiri@resnulli.us,
Michael Shych <michaelsh@mellanox.com>
Subject: Re: [patch v8 1/1] i2c: add master driver for mellanox systems
Date: Sat, 19 Nov 2016 22:04:44 +0100 [thread overview]
Message-ID: <20161119210444.GB2856@katana> (raw)
In-Reply-To: <1479455458-157627-1-git-send-email-vadimp@mellanox.com>
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
Hi,
looks mostly good. I just found this comment which needs clarification:
> + /*
> + * All upper layers currently are never use transfer with more than
> + * 2 messages.
Have you really checked ALL of the upper layers? And even if so, there
is the dev-interface to userspace which allows for arbitrary I2C
transfers using I2C_RDWR.
> Actually, it's also not so relevant in Mellanox systems
> + * because of HW limitation.
What kind of HW limitation do you mean here? Can Mellanox send more than
two messages?
> Max size of transfer is o more than 20B
"is o more"? Typo?
> + * in current x86 LPCI2C bridge.
What does that mean in result?
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-11-19 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 7:50 [patch v8 1/1] i2c: add master driver for mellanox systems vadimp
2016-11-19 21:04 ` Wolfram Sang [this message]
2016-11-20 5:52 ` Vadim Pasternak
2016-11-20 9:02 ` Wolfram Sang
2016-11-20 9:15 ` Vadim Pasternak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161119210444.GB2856@katana \
--to=wsa-dev@sang-engineering.com \
--cc=jiri@resnulli.us \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=vadimp@mellanox.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).