From: Wolfram Sang <wsa@the-dreams.de>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: vz@mleia.com, clg@kaod.org, mouse@mayc.ru, robh+dt@kernel.org,
mark.rutland@arm.com, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, joel@jms.id.au,
openbmc@lists.ozlabs.org
Subject: Re: [PATCH v5 1/2] i2c: aspeed: added driver for Aspeed I2C
Date: Sun, 11 Dec 2016 23:26:22 +0100 [thread overview]
Message-ID: <20161211222622.GK2552@katana> (raw)
In-Reply-To: <1480467618-7497-2-git-send-email-brendanhiggins@google.com>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Tue, Nov 29, 2016 at 05:00:17PM -0800, Brendan Higgins wrote:
> Added initial master and slave support for Aspeed I2C controller.
> Supports fourteen busses present in ast24xx and ast25xx BMC SoCs by
> Aspeed.
>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
BTW first the bindings patch please, then the driver.
And one seperate question I just stumbled over:
> + /* Switch from master mode to slave mode. */
> + func_ctrl_reg_val = aspeed_i2c_read(bus, ASPEED_I2C_FUN_CTRL_REG);
> + func_ctrl_reg_val &= ~ASPEED_I2CD_MASTER_EN;
> + func_ctrl_reg_val |= ASPEED_I2CD_SLAVE_EN;
> + aspeed_i2c_write(bus, func_ctrl_reg_val, ASPEED_I2C_FUN_CTRL_REG);
Can't the hardware work both as master and slave on the same bus?
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-12-11 22:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 1:00 [PATCH v5 0/2] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2016-11-30 1:00 ` [PATCH v5 1/2] " Brendan Higgins
[not found] ` <1480467618-7497-2-git-send-email-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-07 0:57 ` Vladimir Zapolskiy
2017-03-28 5:22 ` Brendan Higgins
2016-12-11 22:26 ` Wolfram Sang [this message]
2016-12-12 11:06 ` Kachalov Anton
[not found] ` <825541481540788-Mr5SgJCofHtxpj1cXAZ9Bg@public.gmane.org>
2016-12-12 11:10 ` Wolfram Sang
2017-03-28 5:23 ` Brendan Higgins
[not found] ` <1480467618-7497-1-git-send-email-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-11-30 1:00 ` [PATCH v5 2/2] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
2016-12-05 22:28 ` Rob Herring
[not found] ` <1480467618-7497-3-git-send-email-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-12-07 0:19 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161211222622.GK2552@katana \
--to=wsa@the-dreams.de \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mouse@mayc.ru \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).