From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 4/5] mfd: axp20x: Drop wrong AXP288_PMIC_ADC_EN define
Date: Tue, 3 Jan 2017 17:54:35 +0000 [thread overview]
Message-ID: <20170103175435.GJ27589@dell> (raw)
In-Reply-To: <20161214135209.16369-4-hdegoede@redhat.com>
On Wed, 14 Dec 2016, Hans de Goede wrote:
> The adc-enable register for the axp288 is 0x82, not 0x84.
> 0x82 is already defined as AXP20X_ADC_EN1 and that is what the
> axp288_adc driver is actually using, so simply drop the wrong
> AXP288_PMIC_ADC_EN define.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> include/linux/mfd/axp20x.h | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index 199cce3..fe93e00 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -232,7 +232,6 @@ enum {
> #define AXP288_PMIC_ADC_H 0x56
> #define AXP288_PMIC_ADC_L 0x57
> #define AXP288_ADC_TS_PIN_CTRL 0x84
> -#define AXP288_PMIC_ADC_EN 0x84
>
> /* Fuel Gauge */
> #define AXP288_FG_RDC1_REG 0xba
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-03 17:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 13:52 [PATCH 1/5] mfd: axp20x: Use IRQF_TRIGGER_LOW on the axp288 Hans de Goede
2016-12-14 13:52 ` [PATCH 2/5] mfd: axp20x: Add missing axp288 irqs Hans de Goede
2016-12-14 14:21 ` Chen-Yu Tsai
2017-01-03 17:54 ` Lee Jones
2016-12-14 13:52 ` [PATCH 3/5] mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped Hans de Goede
2016-12-14 14:28 ` Chen-Yu Tsai
2017-01-03 17:54 ` Lee Jones
2016-12-14 13:52 ` [PATCH 4/5] mfd: axp20x: Drop wrong AXP288_PMIC_ADC_EN define Hans de Goede
2016-12-14 14:29 ` Chen-Yu Tsai
2017-01-03 17:54 ` Lee Jones [this message]
2016-12-14 13:52 ` [PATCH 5/5] mfd: axp20x: Fix axp288 volatile ranges Hans de Goede
2016-12-14 14:41 ` Chen-Yu Tsai
2016-12-14 15:07 ` Hans de Goede
2016-12-15 15:44 ` Hans de Goede
2016-12-14 14:19 ` [PATCH 1/5] mfd: axp20x: Use IRQF_TRIGGER_LOW on the axp288 Chen-Yu Tsai
2017-01-03 17:53 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103175435.GJ27589@dell \
--to=lee.jones@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).