From: Tony Lindgren <tony@atomide.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, wsa@the-dreams.de,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: busses: constify dev_pm_ops structures
Date: Tue, 17 Jan 2017 15:23:49 -0800 [thread overview]
Message-ID: <20170117232349.GY7403@atomide.com> (raw)
In-Reply-To: <1484474381-1064-1-git-send-email-bhumirks@gmail.com>
* Bhumika Goyal <bhumirks@gmail.com> [170115 02:00]:
> Declare dev_pm_ops structures as const as they are only stored in the pm
> field of a device_driver structure. This field is of type const, so
> dev_pm_ops structures having similar properties can be declared const
> too.
>
> File size before: drivers/i2c/busses/i2c-omap.o
> text data bss dec hex filename
> 6814 584 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o
>
> File size after: drivers/i2c/busses/i2c-omap.o
> text data bss dec hex filename
> 7006 392 0 7398 1ce6 drivers/i2c/busses/i2c-omap.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/i2c/busses/i2c-omap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index c7da0c4..1ebb5e9 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -1504,7 +1504,7 @@ static int omap_i2c_runtime_resume(struct device *dev)
> return 0;
> }
>
> -static struct dev_pm_ops omap_i2c_pm_ops = {
> +static const struct dev_pm_ops omap_i2c_pm_ops = {
> SET_RUNTIME_PM_OPS(omap_i2c_runtime_suspend,
> omap_i2c_runtime_resume, NULL)
> };
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-01-17 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 9:59 [PATCH] i2c: busses: constify dev_pm_ops structures Bhumika Goyal
2017-01-17 23:23 ` Tony Lindgren [this message]
2017-01-25 21:03 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117232349.GY7403@atomide.com \
--to=tony@atomide.com \
--cc=bhumirks@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).