linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: "Daniel Vetter" <daniel.vetter@intel.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Jarkko Nikula" <jarkko.nikula@linux.intel.com>,
	"Wolfram Sang" <wsa@the-dreams.de>, "Len Brown" <lenb@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"H . Peter Anvin" <hpa@zytor.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Takashi Iwai <tiwai@suse.de>,
	"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
	linux-i2c@vger.kernel.org
Subject: [PATCH v2 09/13] i2c: designware-baytrail: Acquire P-Unit access on bus acquire
Date: Mon, 23 Jan 2017 22:09:54 +0100	[thread overview]
Message-ID: <20170123210958.18410-10-hdegoede@redhat.com> (raw)
In-Reply-To: <20170123210958.18410-1-hdegoede@redhat.com>

Acquire P-Unit access to stop others from accessing the P-Unit while the
PMIC i2c bus is in use. This is necessary because accessing the P-Unit
from the kernel may result in the P-Unit trying to access the PMIC i2c
bus, which results in a hang when it happens while we own the PMIC i2c
bus semaphore.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=155241
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: tagorereddy <tagore.chandan@gmail.com>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
---
Changes in v2:
-Spelling: P-Unit, PMIC
-Adjust for iosf_mbi_punit_lock/_unlock to _acquire/_release rename
---
 drivers/i2c/busses/i2c-designware-baytrail.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/i2c/busses/i2c-designware-baytrail.c b/drivers/i2c/busses/i2c-designware-baytrail.c
index 3effc9a..7eddc3b 100644
--- a/drivers/i2c/busses/i2c-designware-baytrail.c
+++ b/drivers/i2c/busses/i2c-designware-baytrail.c
@@ -62,6 +62,8 @@ static void reset_semaphore(struct dw_i2c_dev *dev)
 		dev_err(dev->dev, "iosf failed to reset punit semaphore during write\n");
 
 	pm_qos_update_request(&dev->pm_qos, PM_QOS_DEFAULT_VALUE);
+
+	iosf_mbi_punit_release();
 }
 
 static int baytrail_i2c_acquire(struct dw_i2c_dev *dev)
@@ -79,6 +81,8 @@ static int baytrail_i2c_acquire(struct dw_i2c_dev *dev)
 	if (!dev->release_lock)
 		return 0;
 
+	iosf_mbi_punit_acquire();
+
 	/*
 	 * Disallow the CPU to enter C6 or C7 state, entering these states
 	 * requires the punit to talk to the pmic and if this happens while
-- 
2.9.3

  parent reply	other threads:[~2017-01-23 21:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-23 21:09 [PATCH v2 00/13] coordinate cht i2c-pmic and i915-punit accesses Hans de Goede
2017-01-23 21:09 ` [PATCH v2 01/13] x86/platform/intel/iosf_mbi: Add a mutex for P-Unit access Hans de Goede
2017-01-23 21:09 ` [PATCH v2 02/13] x86/platform/intel/iosf_mbi: Add a PMIC bus access notifier Hans de Goede
2017-01-23 21:09 ` [PATCH v2 03/13] i2c: designware: Rename accessor_flags to flags Hans de Goede
2017-01-23 21:09 ` [PATCH v2 04/13] i2c: designware-baytrail: Pass dw_i2c_dev into helper functions Hans de Goede
2017-01-23 21:09 ` [PATCH v2 05/13] i2c: designware-baytrail: Only check iosf_mbi_available() for shared hosts Hans de Goede
2017-01-23 21:09 ` [PATCH v2 06/13] i2c: designware-baytrail: Disallow the CPU to enter C6 or C7 while holding the punit semaphore Hans de Goede
2017-01-24  9:51   ` Andy Shevchenko
2017-01-24 16:48     ` Hans de Goede
2017-01-23 21:09 ` [PATCH v2 07/13] i2c: designware-baytrail: Fix race when resetting the semaphore Hans de Goede
2017-01-23 21:09 ` [PATCH v2 08/13] i2c: designware-baytrail: Add support for cherrytrail Hans de Goede
2017-01-23 21:09 ` Hans de Goede [this message]
2017-01-27 11:29   ` [PATCH v2 09/13] i2c: designware-baytrail: Acquire P-Unit access on bus acquire Jarkko Nikula
2017-01-23 21:09 ` [PATCH v2 10/13] i2c: designware-baytrail: Call pmic_bus_access_notifier_chain Hans de Goede
2017-01-27 11:35   ` Jarkko Nikula
2017-01-23 21:09 ` [PATCH v2 11/13] drm/i915: Add intel_uncore_suspend / resume functions Hans de Goede
2017-01-27 13:45   ` Ville Syrjälä
2017-01-28 16:05     ` Hans de Goede
2017-01-23 21:09 ` [PATCH v2 12/13] drm/i915: Listen for PMIC bus access notifications Hans de Goede
2017-01-27 13:52   ` Ville Syrjälä
2017-01-28 17:39     ` Hans de Goede
2017-01-23 21:09 ` [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings Hans de Goede
2017-01-27 13:51   ` Ville Syrjälä
2017-01-28 16:25     ` Hans de Goede
2017-01-28 17:18       ` Hans de Goede
2017-01-30 13:10         ` Ville Syrjälä
2017-01-30 15:02           ` Hans de Goede
2017-01-30 15:11             ` Ville Syrjälä
2017-01-30 15:27               ` Hans de Goede
2017-01-30 15:38                 ` Ville Syrjälä
2017-01-30 16:33                   ` Hans de Goede
2017-02-10 10:19               ` Hans de Goede
2017-01-25 20:18 ` [PATCH v2 00/13] coordinate cht i2c-pmic and i915-punit accesses Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123210958.18410-10-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hpa@zytor.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=russianneuromancer@ya.ru \
    --cc=tglx@linutronix.de \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).