From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings Date: Fri, 27 Jan 2017 15:51:47 +0200 Message-ID: <20170127135147.GS31595@intel.com> References: <20170123210958.18410-1-hdegoede@redhat.com> <20170123210958.18410-14-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170123210958.18410-14-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: Wolfram Sang , "russianneuromancer @ ya . ru" , intel-gfx , linux-i2c@vger.kernel.org, Jarkko Nikula , dri-devel@lists.freedesktop.org, "H . Peter Anvin" , Daniel Vetter , Thomas Gleixner , Andy Shevchenko , Mika Westerberg , Len Brown List-Id: linux-i2c@vger.kernel.org T24gTW9uLCBKYW4gMjMsIDIwMTcgYXQgMTA6MDk6NThQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBNYWtlIHN1cmUgdGhlIFAtVW5pdCBvciB0aGUgUE1JQyBpMmMgYnVzIGlzIG5vdCBp biB1c2Ugd2hlbiB3ZSBzZW5kIGEKPiByZXF1ZXN0IHRvIHRoZSBQLVVuaXQgYnkgY2FsbGluZyBp b3NmX21iaV9wdW5pdF9hY3F1aXJlKCkgLyBfcmVsZWFzZSgpCj4gYXJvdW5kIFAtVW5pdCB3cml0 ZSBhY2Nlc3Nlcy4KCkNhbid0IHdlIGp1c3Qgc3R1ZmYgdGhlIGNhbGxzIGludG8gdGhlIGFjdHVh bCBwdW5pdCB3cml0ZSBmdW5jdGlvbgpyYXRoZXIgdGhhbiBzcHJpbmtsaW5nIHRoZW0gYWxsIG92 ZXIgdGhlIHBsYWNlPwoKKyBhIGNvbW1lbnQgd291bGQgYmUgbmljZSB3aHkgaXQncyB0aGVyZS4K CkRvIHdlIG5lZWQgYSBrY29uZmlnIHNlbGVjdC9kZXBlbmRzIG9uIHRoZSBpb3NmX21iaSB0aGlu Zz8gT3Igc29tZQppZmRlZnM/Cgo+IAo+IEJ1Z0xpbms6IGh0dHBzOi8vYnVnemlsbGEua2VybmVs Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1MjQxCj4gU2lnbmVkLW9mZi1ieTogSGFucyBkZSBHb2Vk ZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPiBUZXN0ZWQtYnk6IHRhZ29yZXJlZGR5IDx0YWdvcmUu Y2hhbmRhbkBnbWFpbC5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2MjoKPiAtU3BlbGxpbmc6IFAt VW5pdCwgUE1JQwo+IC1BZGp1c3QgZm9yIGlvc2ZfbWJpX3B1bml0X2xvY2svX3VubG9jayB0byBf YWNxdWlyZS9fcmVsZWFzZSByZW5hbWUKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jICAgIHwgNiArKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cG0uYyAgICAgICAgIHwgOSArKysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cnVudGltZV9wbS5jIHwgOSArKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRp b25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDU2MDQ3 MDEuLjEzZTUxNTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAg LTQ3LDYgKzQ3LDcgQEAKPiAgI2luY2x1ZGUgPGRybS9kcm1fcmVjdC5oPgo+ICAjaW5jbHVkZSA8 bGludXgvZG1hX3JlbWFwcGluZy5oPgo+ICAjaW5jbHVkZSA8bGludXgvcmVzZXJ2YXRpb24uaD4K PiArI2luY2x1ZGUgPGFzbS9pb3NmX21iaS5oPgo+ICAKPiAgc3RhdGljIGJvb2wgaXNfbW1pb193 b3JrKHN0cnVjdCBpbnRlbF9mbGlwX3dvcmsgKndvcmspCj4gIHsKPiBAQCAtNjQyMSw2ICs2NDIy LDggQEAgc3RhdGljIHZvaWQgdmFsbGV5dmlld19zZXRfY2RjbGsoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgaW50IGNkY2xrKQo+ICAJCWNtZCA9IDA7Cj4gIAo+ICAJbXV0ZXhfbG9jaygmZGV2X3By aXYtPnJwcy5od19sb2NrKTsKPiArCWlvc2ZfbWJpX3B1bml0X2FjcXVpcmUoKTsKPiArCj4gIAl2 YWwgPSB2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX0RTUEZSRVEpOwo+ICAJdmFs ICY9IH5EU1BGUkVRR1VBUl9NQVNLOwo+ICAJdmFsIHw9IChjbWQgPDwgRFNQRlJFUUdVQVJfU0hJ RlQpOwo+IEBAIC02NDMwLDYgKzY0MzMsNyBAQCBzdGF0aWMgdm9pZCB2YWxsZXl2aWV3X3NldF9j ZGNsayhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY2RjbGspCj4gIAkJICAgICA1MCkpIHsK PiAgCQlEUk1fRVJST1IoInRpbWVkIG91dCB3YWl0aW5nIGZvciBDRGNsayBjaGFuZ2VcbiIpOwo+ ICAJfQo+ICsJaW9zZl9tYmlfcHVuaXRfcmVsZWFzZSgpOwo+ICAJbXV0ZXhfdW5sb2NrKCZkZXZf cHJpdi0+cnBzLmh3X2xvY2spOwo+ICAKPiAgCW11dGV4X2xvY2soJmRldl9wcml2LT5zYl9sb2Nr KTsKPiBAQCAtNjQ5Nyw2ICs2NTAxLDcgQEAgc3RhdGljIHZvaWQgY2hlcnJ5dmlld19zZXRfY2Rj bGsoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGNkY2xrKQo+ICAJY21kID0gRElWX1JPVU5E X0NMT1NFU1QoZGV2X3ByaXYtPmhwbGxfZnJlcSA8PCAxLCBjZGNsaykgLSAxOwo+ICAKPiAgCW11 dGV4X2xvY2soJmRldl9wcml2LT5ycHMuaHdfbG9jayk7Cj4gKwlpb3NmX21iaV9wdW5pdF9hY3F1 aXJlKCk7Cj4gIAl2YWwgPSB2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX0RTUEZS RVEpOwo+ICAJdmFsICY9IH5EU1BGUkVRR1VBUl9NQVNLX0NIVjsKPiAgCXZhbCB8PSAoY21kIDw8 IERTUEZSRVFHVUFSX1NISUZUX0NIVik7Cj4gQEAgLTY1MDYsNiArNjUxMSw3IEBAIHN0YXRpYyB2 b2lkIGNoZXJyeXZpZXdfc2V0X2NkY2xrKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBjZGNs aykKPiAgCQkgICAgIDUwKSkgewo+ICAJCURSTV9FUlJPUigidGltZWQgb3V0IHdhaXRpbmcgZm9y IENEY2xrIGNoYW5nZVxuIik7Cj4gIAl9Cj4gKwlpb3NmX21iaV9wdW5pdF9yZWxlYXNlKCk7Cj4g IAltdXRleF91bmxvY2soJmRldl9wcml2LT5ycHMuaHdfbG9jayk7Cj4gIAo+ICAJaW50ZWxfdXBk YXRlX2NkY2xrKGRldl9wcml2KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBpbmRleCAyNDk2 MjNkLi5hZGZmODRhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gQEAgLTMyLDYgKzMy LDcgQEAKPiAgI2luY2x1ZGUgIi4uLy4uLy4uL3BsYXRmb3JtL3g4Ni9pbnRlbF9pcHMuaCIKPiAg I2luY2x1ZGUgPGxpbnV4L21vZHVsZS5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVs cGVyLmg+Cj4gKyNpbmNsdWRlIDxhc20vaW9zZl9tYmkuaD4KPiAgCj4gIC8qKgo+ICAgKiBET0M6 IFJDNgo+IEBAIC0yNzYsNiArMjc3LDcgQEAgc3RhdGljIHZvaWQgY2h2X3NldF9tZW1vcnlfZHZm cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgZW5hYmxlKQo+ICAJdTMy IHZhbDsKPiAgCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ICsJaW9z Zl9tYmlfcHVuaXRfYWNxdWlyZSgpOwo+ICAKPiAgCXZhbCA9IHZsdl9wdW5pdF9yZWFkKGRldl9w cml2LCBQVU5JVF9SRUdfRERSX1NFVFVQMik7Cj4gIAlpZiAoZW5hYmxlKQo+IEBAIC0yOTAsNiAr MjkyLDcgQEAgc3RhdGljIHZvaWQgY2h2X3NldF9tZW1vcnlfZHZmcyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgZW5hYmxlKQo+ICAJCSAgICAgIEZPUkNFX0REUl9GUkVR X1JFUV9BQ0spID09IDAsIDMpKQo+ICAJCURSTV9FUlJPUigidGltZWQgb3V0IHdhaXRpbmcgZm9y IFB1bml0IEREUiBEVkZTIHJlcXVlc3RcbiIpOwo+ICAKPiArCWlvc2ZfbWJpX3B1bml0X3JlbGVh c2UoKTsKPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPnJwcy5od19sb2NrKTsKPiAgfQo+ICAK PiBAQCAtMjk4LDYgKzMwMSw3IEBAIHN0YXRpYyB2b2lkIGNodl9zZXRfbWVtb3J5X3BtNShzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGJvb2wgZW5hYmxlKQo+ICAJdTMyIHZhbDsK PiAgCj4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cnBzLmh3X2xvY2spOwo+ICsJaW9zZl9tYmlf cHVuaXRfYWNxdWlyZSgpOwo+ICAKPiAgCXZhbCA9IHZsdl9wdW5pdF9yZWFkKGRldl9wcml2LCBQ VU5JVF9SRUdfRFNQRlJFUSk7Cj4gIAlpZiAoZW5hYmxlKQo+IEBAIC0zMDYsNiArMzEwLDcgQEAg c3RhdGljIHZvaWQgY2h2X3NldF9tZW1vcnlfcG01KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiwgYm9vbCBlbmFibGUpCj4gIAkJdmFsICY9IH5EU1BfTUFYRklGT19QTTVfRU5BQkxF Owo+ICAJdmx2X3B1bml0X3dyaXRlKGRldl9wcml2LCBQVU5JVF9SRUdfRFNQRlJFUSwgdmFsKTsK PiAgCj4gKwlpb3NmX21iaV9wdW5pdF9yZWxlYXNlKCk7Cj4gIAltdXRleF91bmxvY2soJmRldl9w cml2LT5ycHMuaHdfbG9jayk7Cj4gIH0KPiAgCj4gQEAgLTQ1NTMsNiArNDU1OCw3IEBAIHZvaWQg dmx2X3dtX2dldF9od19zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAKPiAgCWlmIChJ U19DSEVSUllWSUVXKGRldl9wcml2KSkgewo+ICAJCW11dGV4X2xvY2soJmRldl9wcml2LT5ycHMu aHdfbG9jayk7Cj4gKwkJaW9zZl9tYmlfcHVuaXRfYWNxdWlyZSgpOwo+ICAKPiAgCQl2YWwgPSB2 bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX0RTUEZSRVEpOwo+ICAJCWlmICh2YWwg JiBEU1BfTUFYRklGT19QTTVfRU5BQkxFKQo+IEBAIC00NTgyLDYgKzQ1ODgsNyBAQCB2b2lkIHZs dl93bV9nZXRfaHdfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQkJCXdtLT5sZXZl bCA9IFZMVl9XTV9MRVZFTF9ERFJfRFZGUzsKPiAgCQl9Cj4gIAo+ICsJCWlvc2ZfbWJpX3B1bml0 X3JlbGVhc2UoKTsKPiAgCQltdXRleF91bmxvY2soJmRldl9wcml2LT5ycHMuaHdfbG9jayk7Cj4g IAl9Cj4gIAo+IEBAIC00OTg4LDcgKzQ5OTUsOSBAQCBzdGF0aWMgdm9pZCB2YWxsZXl2aWV3X3Nl dF9ycHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCB1OCB2YWwpCj4gIAlJOTE1 X1dSSVRFKEdFTjZfUE1JTlRSTVNLLCBnZW42X3Jwc19wbV9tYXNrKGRldl9wcml2LCB2YWwpKTsK PiAgCj4gIAlpZiAodmFsICE9IGRldl9wcml2LT5ycHMuY3VyX2ZyZXEpIHsKPiArCQlpb3NmX21i aV9wdW5pdF9hY3F1aXJlKCk7Cj4gIAkJdmx2X3B1bml0X3dyaXRlKGRldl9wcml2LCBQVU5JVF9S RUdfR1BVX0ZSRVFfUkVRLCB2YWwpOwo+ICsJCWlvc2ZfbWJpX3B1bml0X3JlbGVhc2UoKTsKPiAg CQlpZiAoIUlTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ICAJCQlnZW42X3NldF9ycHNfdGhyZXNo b2xkcyhkZXZfcHJpdiwgdmFsKTsKPiAgCX0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcnVudGltZV9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcnVu dGltZV9wbS5jCj4gaW5kZXggYzBiN2U5NS4uZTY2YmNjOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9ydW50aW1lX3BtLmMKPiBAQCAtMjgsNiArMjgsNyBAQAo+ICAKPiAgI2luY2x1 ZGUgPGxpbnV4L3BtX3J1bnRpbWUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L3ZnYWFyYi5oPgo+ICsj aW5jbHVkZSA8YXNtL2lvc2ZfbWJpLmg+Cj4gIAo+ICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiAg I2luY2x1ZGUgImludGVsX2Rydi5oIgo+IEBAIC0xMDI3LDYgKzEwMjgsOCBAQCBzdGF0aWMgdm9p ZCB2bHZfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ ICAJaWYgKENPTkQpCj4gIAkJZ290byBvdXQ7Cj4gIAo+ICsJaW9zZl9tYmlfcHVuaXRfYWNxdWly ZSgpOwo+ICsKPiAgCWN0cmwgPSB2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX1BX UkdUX0NUUkwpOwo+ICAJY3RybCAmPSB+bWFzazsKPiAgCWN0cmwgfD0gc3RhdGU7Cj4gQEAgLTEw MzcsNiArMTA0MCw4IEBAIHN0YXRpYyB2b2lkIHZsdl9zZXRfcG93ZXJfd2VsbChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgc3RhdGUsCj4gIAkJCSAgdmx2X3B1bml0 X3JlYWQoZGV2X3ByaXYsIFBVTklUX1JFR19QV1JHVF9DVFJMKSk7Cj4gIAo+ICsJaW9zZl9tYmlf cHVuaXRfcmVsZWFzZSgpOwo+ICsKPiAgI3VuZGVmIENPTkQKPiAgCj4gIG91dDoKPiBAQCAtMTY0 Myw2ICsxNjQ4LDggQEAgc3RhdGljIHZvaWQgY2h2X3NldF9waXBlX3Bvd2VyX3dlbGwoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJaWYgKENPTkQpCj4gIAkJZ290byBvdXQ7 Cj4gIAo+ICsJaW9zZl9tYmlfcHVuaXRfYWNxdWlyZSgpOwo+ICsKPiAgCWN0cmwgPSB2bHZfcHVu aXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX0RTUEZSRVEpOwo+ICAJY3RybCAmPSB+RFBfU1ND X01BU0socGlwZSk7Cj4gIAljdHJsIHw9IGVuYWJsZSA/IERQX1NTQ19QV1JfT04ocGlwZSkgOiBE UF9TU0NfUFdSX0dBVEUocGlwZSk7Cj4gQEAgLTE2NTMsNiArMTY2MCw4IEBAIHN0YXRpYyB2b2lk IGNodl9zZXRfcGlwZV9wb3dlcl93ZWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgCQkJICBzdGF0ZSwKPiAgCQkJICB2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRf UkVHX0RTUEZSRVEpKTsKPiAgCj4gKwlpb3NmX21iaV9wdW5pdF9yZWxlYXNlKCk7Cj4gKwo+ICAj dW5kZWYgQ09ORAo+ICAKPiAgb3V0Ogo+IC0tIAo+IDIuOS4zCgotLSAKVmlsbGUgU3lyasOkbMOk CkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK