From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 13/13] drm/i915: Acquire P-Unit access when modifying P-Unit settings Date: Mon, 30 Jan 2017 17:38:05 +0200 Message-ID: <20170130153805.GQ31595@intel.com> References: <20170123210958.18410-1-hdegoede@redhat.com> <20170123210958.18410-14-hdegoede@redhat.com> <20170127135147.GS31595@intel.com> <64a4aef7-837f-059c-9be5-4a76602488be@redhat.com> <2eea197f-2485-5f93-1691-42a9a2e11267@redhat.com> <20170130131041.GM31595@intel.com> <20170130151144.GP31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Hans de Goede Cc: Wolfram Sang , Takashi Iwai , "russianneuromancer @ ya . ru" , intel-gfx , linux-i2c@vger.kernel.org, Jarkko Nikula , dri-devel@lists.freedesktop.org, "H . Peter Anvin" , Daniel Vetter , Thomas Gleixner , Andy Shevchenko , Mika Westerberg , Len Brown List-Id: linux-i2c@vger.kernel.org T24gTW9uLCBKYW4gMzAsIDIwMTcgYXQgMDQ6Mjc6NThQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBIaSwKPiAKPiBPbiAzMC0wMS0xNyAxNjoxMSwgVmlsbGUgU3lyasOkbMOkIHdyb3Rl Ogo+ID4gT24gTW9uLCBKYW4gMzAsIDIwMTcgYXQgMDQ6MDI6MTlQTSArMDEwMCwgSGFucyBkZSBH b2VkZSB3cm90ZToKPiA+PiBIaSwKPiA+Pgo+ID4+IE9uIDMwLTAxLTE3IDE0OjEwLCBWaWxsZSBT eXJqw6Rsw6Qgd3JvdGU6Cj4gPj4+IE9uIFNhdCwgSmFuIDI4LCAyMDE3IGF0IDA2OjE4OjQ1UE0g KzAxMDAsIEhhbnMgZGUgR29lZGUgd3JvdGU6Cj4gPj4+PiBIaSwKPiA+Pj4+Cj4gPj4+PiBPbiAw MS8yOC8yMDE3IDA1OjI1IFBNLCBIYW5zIGRlIEdvZWRlIHdyb3RlOgo+ID4+Pj4+IEhpLAo+ID4+ Pj4+Cj4gPj4+Pj4gT24gMDEvMjcvMjAxNyAwMjo1MSBQTSwgVmlsbGUgU3lyasOkbMOkIHdyb3Rl Ogo+ID4+Pj4+PiBPbiBNb24sIEphbiAyMywgMjAxNyBhdCAxMDowOTo1OFBNICswMTAwLCBIYW5z IGRlIEdvZWRlIHdyb3RlOgo+ID4+Pj4+Pj4gTWFrZSBzdXJlIHRoZSBQLVVuaXQgb3IgdGhlIFBN SUMgaTJjIGJ1cyBpcyBub3QgaW4gdXNlIHdoZW4gd2Ugc2VuZCBhCj4gPj4+Pj4+PiByZXF1ZXN0 IHRvIHRoZSBQLVVuaXQgYnkgY2FsbGluZyBpb3NmX21iaV9wdW5pdF9hY3F1aXJlKCkgLyBfcmVs ZWFzZSgpCj4gPj4+Pj4+PiBhcm91bmQgUC1Vbml0IHdyaXRlIGFjY2Vzc2VzLgo+ID4+Pj4+Pgo+ ID4+Pj4+PiBDYW4ndCB3ZSBqdXN0IHN0dWZmIHRoZSBjYWxscyBpbnRvIHRoZSBhY3R1YWwgcHVu aXQgd3JpdGUgZnVuY3Rpb24KPiA+Pj4+Pj4gcmF0aGVyIHRoYW4gc3ByaW5rbGluZyB0aGVtIGFs bCBvdmVyIHRoZSBwbGFjZT8KPiA+Pj4+Pgo+ID4+Pj4+IHB1bml0IGFjY2VzcyBpcyBhY3F1aXJl ZCBhY3Jvc3Mgc2VjdGlvbnMgbGlrZSB0aGlzOgo+ID4+Pj4+Cj4gPj4+Pj4gICAgICAgICBpb3Nm X21iaV9wdW5pdF9hY3F1aXJlKCk7Cj4gPj4+Pj4KPiA+Pj4+PiAgICAgICAgIHZhbCA9IHZsdl9w dW5pdF9yZWFkKGRldl9wcml2LCBQVU5JVF9SRUdfRFNQRlJFUSk7Cj4gPj4+Pj4gICAgICAgICB2 YWwgJj0gfkRTUEZSRVFHVUFSX01BU0s7Cj4gPj4+Pj4gICAgICAgICB2YWwgfD0gKGNtZCA8PCBE U1BGUkVRR1VBUl9TSElGVCk7Cj4gPj4+Pj4gICAgICAgICB2bHZfcHVuaXRfd3JpdGUoZGV2X3By aXYsIFBVTklUX1JFR19EU1BGUkVRLCB2YWwpOwo+ID4+Pj4+ICAgICAgICAgaWYgKHdhaXRfZm9y KCh2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX0RTUEZSRVEpICYKPiA+Pj4+PiAg ICAgICAgICAgICAgICAgICAgICAgRFNQRlJFUVNUQVRfTUFTSykgPT0gKGNtZCA8PCBEU1BGUkVR U1RBVF9TSElGVCksCj4gPj4+Pj4gICAgICAgICAgICAgICAgICAgICAgNTApKSB7Cj4gPj4+Pj4g ICAgICAgICAgICAgICAgIERSTV9FUlJPUigidGltZWQgb3V0IHdhaXRpbmcgZm9yIENEY2xrIGNo YW5nZVxuIik7Cj4gPj4+Pj4gICAgICAgICB9Cj4gPj4+Pj4gICAgICAgICBpb3NmX21iaV9wdW5p dF9yZWxlYXNlKCk7Cj4gPj4+Pj4KPiA+Pj4+PiBXaGVyZSB3ZSB3YW50IHRvIHdhaXQgZm9yIHRo ZSByZXF1ZXN0ZWQgY2hhbmdlIHRvIGhhdmUgdGFrZW4KPiA+Pj4+PiBlZmZlY3QgYmVmb3JlIHJl bGVhc2luZyB0aGUgcHVuaXQuCj4gPj4+Cj4gPj4+IEhtbS4gVGhhdCdzIHNvbWV3aGF0IHVuZm9y dHVuYXRlLiBJdCBhbHNvIGhpZ2hsaWdodHMgYSBwcm9ibGVtIHdpdGggdGhlCj4gPj4+IHBhdGNo IHdydC4gUlBTLiBXZSBkb24ndCB3YWl0IGZvciB0aGUgR1BVIHRvIGFjdHVhbGx5IGNoYW5nZSBm cmVxdWVuY2llcwo+ID4+PiBpbiBzZXRfcnBzKCkgYmVjYXVzZSB0aGF0IHdvdWxkIHNsb3cgdGhp bmdzIGRvd24gdG9vIG11Y2guIFNvIEkgaGF2ZSB0bwo+ID4+PiB3b25kZXIgaG93IG11Y2ggbHVj ayBpcyBuZWVkZWQgdG8gbWFrZSB0aGlzIHdvcmthcm91bmQgcmVhbGx5IGVmZmVjdGl2ZS4KPiA+ Pgo+ID4+IFNvIHRoZSBoaXN0b3J5IG9mIHRoaXMgcGF0Y2gtc2V0IGlzIHRoYXQgSSB3cm90ZSB0 aGlzIHBhdGNoIGJlZm9yZQo+ID4+IHdyaXRpbmcgdGhlIHBhdGNoIHRvIGdldCBGT1JDRVdBS0Vf QUxMIGJlZm9yZSB0aGUgcG1pYyBidXMgYmVjb21lcwo+ID4+IGFjdGl2ZSAocGF0Y2ggMTIvMTMp LiBTaW5jZSBhIGxvdCBvZiB0ZXN0aW5nIHdhcyBkb25lIHdpdGggdGhpcwo+ID4+IHBhdGNoIGlu Y2x1ZGVkIGluIHRoZSBwYXRjaC1zZXQgYW5kIHNpbmNlIGl0IHNlZW1lZCBhIGdvb2QgaWRlYQo+ ID4+IHJlZ2FyZGxlc3MgKGdpdmVuIG15IGV4cGVyaWVuY2Ugd2l0aCBhY2Nlc3NpbmcgdGhlIHB1 bml0IHZzCj4gPj4gcG1pYyBidXMgYWNjZXNzZXMpIEkgZGVjaWRlZCB0byBsZWF2ZSBpdCBpbi4K PiA+Pgo+ID4+IFBvc3NpYmx5IGp1c3QgdGhlIHBhdGNoIHRvIGdldCBGT1JDRVdBS0VfQUxMIGlz IGVub3VnaCwgdGhhdCBvbmUKPiA+PiBhY3R1YWxseSBmaXhlZCB0aGluZ3MgZm9yIG1lLiBUaGF0 IGlzIGFsc28gd2h5IEkgbWFkZSB0aGlzIHRoZQo+ID4+IGxhc3QgcGF0Y2ggaW4gdGhlIHNldC4g SSBhc2tlZCB0YWdvcmVyZWRkeSB0byB0ZXN0IGhpcyBzeXN0ZW0KPiA+PiB3aXRob3V0IHRoaXMg cGF0Y2gsIGJ1dCBoZSBkaWQgbm90IGdldCBhcm91bmQgdG8gdGhhdC4KPiA+Pgo+ID4+IEFmdGVy IGFsbCB3ZSBkbyB0ZWxsIHRoZSBwdW5pdCB0byBub3QgdG91Y2ggdGhlIGJ1cyBieSBhY3F1aXJp bmcKPiA+PiB0aGUgcG1pYyBidXMgc2VtYXBob3JlIGZyb20gaTJjLWRlc2lnd2FyZS1iYXl0cmFp bC5jLCBzbyBtYXliZQo+ID4+IGZvciBSUFMgZnJlcSBjaGFuZ2VzIGl0IGhvbm9ycyB0aGF0IGFu ZCBwcm9wZXJseSB3YWl0cy4gTWF5YmUgaXQKPiA+PiBob25vcnMgdGhhdCBmb3IgYWxsIHB1bml0 IHJlcXVlc3RzIGk5MTUgZG9lcyBhbmQgdGhlIG9ubHkgcmVhbAo+ID4+IHByb2JsZW0gaXMgdGhl IGZvcmNld2FrZSBzdHVmZiA/Cj4gPj4KPiA+PiBJIGNhbiB0cnkgdG8gZHJvcCB0aGlzIHBhdGNo IGZyb20gbXkgcXVldWUgYW5kIHJ1biB3aXRob3V0IGl0Cj4gPj4gZm9yIGEgd2hpbGUgYW5kIHNl ZSBpZiB0aGluZ3MgZG9uJ3QgcmVncmVzcy4gQW5kIGFsc28gYXNrCj4gPj4gdGFnb3JlcmVkZHkg YWdhaW4gdG8gdGVzdCBoaXMgc3lzdGVtIHRoYXQgd2F5Lgo+ID4+Cj4gPj4gRG9lcyB0aGF0IChk cm9wcGluZyB0aGlzIHBhdGNoIGZvciBub3cpIHNvdW5kIGxpa2UgYSBnb29kIGlkZWE/Cj4gPgo+ ID4gTW9yZSB0ZXN0IHJlc3VsdHMgY291bGRuJ3QgaHVydCBhdCBsZWFzdC4gSXQgYWxzbyBtYWtl cyBtZSB3b25kZXIgaWYKPiA+IGp1c3QgYnVtcGluZyB0aGUgdGltZW91dHMgdG8gc29tZSByaWRp Y3Vsb3VzbHkgaGlnaCB2YWx1ZSB3b3VsZCBmaXgKPiA+IHRoZSBwcm9ibGVtIGFzIHdlbGwuCj4g Cj4gSSd2ZSBhbHJlYWR5IHRyaWVkIGJ1bXBpbmcgdGhlIGZvcmNld2FrZSB0aW1lb3V0IGZyb20g NTAgdG8gMjUwbXMsCj4gYmVmb3JlIHdyaXRpbmcgdGhlIHBhdGNoIHRvIGp1c3QgZ2V0IGZvcmNl d2FrZV9hbGwgYmVmb3JlIHRoZSBwbWljCj4gYnVzIGFjY2VzcyBiZWdpbnMsIHRoYXQgZG9lcyBu b3QgZml4IHRoaW5ncywKCkFuZCB5b3UgYnVtcGVkIHRoZSBpMmMgbXV0ZXggdGltZW91dCBhcyB3 ZWxsPyBPciBkb2VzIHRoYXQgZmFpbCBzb21laG93CmdyYWNlZnVsbHkgaWYgaXQgY2FuJ3QgZ2V0 IHRoZSBtdXRleD8KCj4gYW5kIHNpbmNlIHdlIGJ1c3kgd2FpdAo+IGZvciB0aGlzIHRpbWVvdXQg ZnJvbSBub24tc2xlZXBpbmcgY29udGV4dCAyNTBtcyBhbHJlYWR5IGlzIHdheSB0b28KPiBoaWdo LgoKU3VyZSwgYnV0IEknbSBqdXN0IHRyeWluZyB0byB1bmRlcnN0YW5kIGlmIHRoZSBwcm9ibGVt IGlzIHNpbXBseSBjYXVzZWQKYnkgcHJvY2VlZGluZyB3aXRoIHNvbWUgaGFyZHdhcmUgYWNjZXNz IHdpdGhvdXQgZ2V0dGluZyB0aGUgaTJjIG11dGV4LgoKPiAKPiA+Pj4+Pj4gKyBhIGNvbW1lbnQg d291bGQgYmUgbmljZSB3aHkgaXQncyB0aGVyZS4KPiA+Pj4+Pgo+ID4+Pj4+IEkgd2lsbCBhZGQg Y29tbWVudHMgdG8gdGhlIGFjcXVpcmUgY2FsbHMuCj4gPj4+Pj4KPiA+Pj4+Pj4gRG8gd2UgbmVl ZCBhIGtjb25maWcgc2VsZWN0L2RlcGVuZHMgb24gdGhlIGlvc2ZfbWJpIHRoaW5nPyBPciBzb21l Cj4gPj4+Pj4+IGlmZGVmcz8KPiA+Pj4+Pgo+ID4+Pj4+IE5vLCB0aGUgaW9zZl9tYmkgaGVhZGVy IGRlZmluZXMgZW1wdHkgaW5saW5lIHZlcnNpb25zIG9mCj4gPj4+Pj4gaW9zZl9tYmlfcHVuaXRf YWNxdWlyZSAvIF9yZWxlYXNlIGlmIElPU0ZfTUJJIGlzIGRpc2FibGVkLAo+ID4+Pj4+IHRoaXMg ZG9lcyBtZWFuIHRoYXQgaW9zZl9tYmkgbXVzdCBiZSBidWlsdGluIGlmIHRoZSBpOTE1Cj4gPj4+ Pj4gZHJpdmVyIGlzLiBJJ2xsIGFkZDoKPiA+Pj4+Pgo+ID4+Pj4+ICAgICBkZXBlbmRzIG9uIERS TV9JOTE1PUlPU0ZfTUJJIHx8IElPU0ZfTUJJPXkKPiA+Pj4+Pgo+ID4+Pj4+IFRvIHRoZSBpOTE1 IEtjb25maWcgdG8gZW5mb3JjZSB0aGlzLgo+ID4+Pj4KPiA+Pj4+IEhtbSwgb2sgc28gdGhhdCBk b2VzIG5vdCB3b3JrIChsb25nIGN5Y2xpYyBkZXBlbmRlbmN5IHRocm91Z2ggdGhlCj4gPj4+PiBz ZWxlY3Rpb24gb2YgQUNQSV9WSURFTykuCj4gPj4+Pgo+ID4+Pj4gU28gSSd2ZSBub3cgYWRkZWQg dGhpcyBpbnN0ZWFkOgo+ID4+Pj4KPiA+Pj4+IAkjIGlvc2ZfbWJpIG5lZWRzIHRvIGJlIGJ1aWx0 aW4gaWYgd2UgYXJlIGJ1aWx0aW4KPiA+Pj4+IAlzZWxlY3QgSU9TRl9NQkkgaWYgRFJNX0k5MTU9 eQo+ID4+Pgo+ID4+PiBUaGF0J3MgcHJvYmFibHkgbm90IGdvaW5nIHRvIGhlbHAgYW55b25lIHNp bmNlIGk5MTUgaXMgdXN1YWxseSBhIG1vZHVsZS4KPiA+Pgo+ID4+IFJpZ2h0LCB0aGF0IGlzIGZp bmUsIHRoZW4gZWl0aGVyIHRoZSBJT1NGX01CSSBzeW1ib2xzIGFyZSBhdmFpbGFibGUsCj4gPj4g b3IgSU9TRl9NQkkgaXMgZGlzYWJsZWQgYW5kIHdlIGdldCB0aGUgaW5saW5lIG5vcHMgZnJvbSB0 aGUgaGVhZGVyLgo+ID4+Cj4gPj4gVGhlIHByb2JsZW0gc2NlbmFyaW8gaXMgRFJNX0k5MTU9eSBh bmQgSU9TRl9NQkk9bSwgd2hpY2ggaXMgbm90IHZlcnkKPiA+PiByZWFsaXN0aWMgSU1ITywgYnV0 IHdpbGwgZ2V0IHRyaWdnZXJlZCBieSB0aGUgcmFuZG9tLWNvbmZpZyB0ZXN0aW5nCj4gPj4gc2V2 ZXJhbCBjb250cmlidXRvcnMgZG8gYW5kIGxlYWQgdG8gYW4gdW5yZXNvbHZlZCBzeW1ib2wgZXJy b3IgdGhlcmUuCj4gPgo+ID4gV2VsbCwgZnJvbSB0aGUgdXNlciBQT1YgYW55dGhpbmcgd2l0aCBJ T1NGX01CST09biBjYW4gYmUgYSBwcm9ibGVtLgo+ID4gU28gSSdtIG5vdCBzdXJlIGlmIHdlIHNo b3VsZCBhbGxvdyB0aGF0Lgo+IAo+IFNvIHlvdSdyZSBzdWdnZXN0aW5nIHdlIGp1c3QgYWRkIGFu IHVuY29uZGl0aW9uYWwgInNlbGVjdCBJT1NGX01CSSIKPiB0byB0aGUgaTkxNSBLY29uZmlnIGVu dHJ5PwoKWWVhaCwgdGhhdCBzaG91bGQgYXQgbGVhc3QgY3V0IGRvd24gdGhlIG51bWJlciBvZiBw ZW9wbGUgYWNjaWRlbnRhbGx5Cm1pc2NvbmZpZ3VyaW5nIHRoZWlyIGtlcm5lbHMgYW5kIGhpdHRp bmcgdGhpcyBwcm9ibGVtIGluIHRoZSBmdXR1cmUuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK