From: Wolfram Sang <wsa@the-dreams.de>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Eric Anholt" <eric@anholt.net>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Martin Sperl" <kernel@martin.sperl.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Frank Rowand" <frowand.list@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
devicetree@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 1/3] i2c: bcm2835: Avoid possible NULL ptr dereference
Date: Tue, 21 Feb 2017 21:14:03 +0100 [thread overview]
Message-ID: <20170221201403.GA1481@katana> (raw)
In-Reply-To: <23773cd4-a9a4-5323-4cc2-71d1d617b232@i2se.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
> >On Thu, Feb 16, 2017 at 09:20:45PM +0000, Stefan Wahren wrote:
> >>Since commit e2474541032d ("bcm2835: Fix hang for writing messages
> >>larger than 16 bytes") the interrupt handler is prone to a possible
> >>NULL pointer dereference. This could happen if an interrupt fires
> >>before curr_msg is set by bcm2835_i2c_xfer_msg() and randomly occurs
> >>on the RPi 3. Even this is an unexpected behavior the driver must
> >>handle that with an error instead of a crash.
> >>
> >>CC: Noralf Trønnes <noralf@tronnes.org>
> >>CC: Martin Sperl <kernel@martin.sperl.org>
> >>Reported-by: Peter Robinson <pbrobinson@gmail.com>
> >>Fixes: e2474541032d ("bcm2835: Fix hang for writing messages larger than 16 bytes")
> >>Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> >Applied to for-next, thanks (will be in 4.11)!
> >
>
> since this patch is too late for 4.10, should i resent with CC to stable in
> order to get it into the next 4.10 release?
It has the Fixes: tag, that will do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-02-21 20:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 21:20 [PATCH RFC 0/3] ARM64: bcm2837-rpi: Fix random crashes caused by i2c Stefan Wahren
2017-02-16 21:20 ` [PATCH RFC 1/3] i2c: bcm2835: Avoid possible NULL ptr dereference Stefan Wahren
[not found] ` <1487280047-29608-2-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2017-02-18 18:34 ` Noralf Trønnes
[not found] ` <48907a31-eaa6-27e2-633f-d36de521e868-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2017-02-20 19:40 ` Stefan Wahren
[not found] ` <1983281189.110224.1487619653742-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-02-20 21:22 ` Noralf Trønnes
[not found] ` <5b14ed6d-4db8-abf7-ceba-ef46534b6023-L59+Z2yzLopAfugRpC6u6w@public.gmane.org>
2017-02-21 8:58 ` Stefan Wahren
[not found] ` <31b96f29-e369-546a-6270-266daea71062-eS4NqCHxEME@public.gmane.org>
2017-02-21 11:54 ` kernel-TqfNSX0MhmxHKSADF0wUEw
2017-02-21 15:07 ` Michael Zoran
2017-02-21 15:37 ` Stefan Wahren
2017-02-20 18:22 ` Wolfram Sang
2017-02-21 16:31 ` Stefan Wahren
2017-02-21 20:14 ` Wolfram Sang [this message]
2017-02-22 7:20 ` Greg Kroah-Hartman
2017-02-28 12:42 ` Stefan Wahren
[not found] ` <77c2af87-6f0e-4de0-18e9-0aa798f282d0-eS4NqCHxEME@public.gmane.org>
2017-02-28 12:47 ` Greg Kroah-Hartman
2017-02-16 21:20 ` [PATCH RFC 2/3] ARM64: bcm2837-rpi: remove link to bcm2835-rpi.dtsi Stefan Wahren
2017-02-16 21:20 ` [PATCH RFC 3/3] ARM64: bcm2837-rpi: Fix pwm and i2c pin control Stefan Wahren
2017-02-27 20:56 ` Eric Anholt
[not found] ` <87r32j8ial.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org>
2017-02-27 21:13 ` Stefan Wahren
2017-02-27 22:36 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221201403.GA1481@katana \
--to=wsa@the-dreams.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@martin.sperl.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=noralf@tronnes.org \
--cc=pbrobinson@gmail.com \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).