From: Pavel Machek <pavel@ucw.cz>
To: Peter Rosin <peda@axentia.se>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>,
Tin Huynh <tnhuynh@apm.com>, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v1 1/2] Revert "i2c: mux: pca954x: Add ACPI support for pca954x"
Date: Thu, 23 Mar 2017 11:04:04 +0100 [thread overview]
Message-ID: <20170323100403.GA9307@amd> (raw)
In-Reply-To: <7d5fba14-d3f1-dfaa-ac7d-5001ccf370a1@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 1666 bytes --]
On Thu 2017-03-23 08:45:58, Peter Rosin wrote:
> On 2017-03-22 14:05, Andy Shevchenko wrote:
> > On Wed, 2017-03-22 at 11:23 +0100, Peter Rosin wrote:
> >> On 2017-03-21 20:13, Andy Shevchenko wrote:
> >>> In ACPI world any ID should be carefully chosen and registered
> >>> officially. The commit bbf9d262a147 seems did a wrong assumption
> >>> because
> >>> PCA is the registered PNP ID for "PHILIPS BU ADD ON CARD". I'm
> >>> pretty
> >>> sure this prefix has nothing to do with the driver in question.
> >>
> >> [Cc: leds people, in case they know any details]
> >>
> >> Hmmm, a couple of questions about that "pretty sure"...
> >
> > I didn't neither see the *real* excerpt from DSDT nor hear anything
> > about official IDs from Phillips.
> >
> >> Philips and NXP are pretty much just different faces of the same coin,
> >> IIUC.
> >
> > Good to know.
> >
> > While I might be mistaken, I would like to remove a confusion until we
> > get an official confirmation either in *real* existing product on the
> > market or letter from Phillips representatives (see above).
>
> Right, I don't disagree with the revert at all. The IDs were
> apparently just grabbed and, as you point out, that is not the ACPI
> way.
>
> One more question though, the revert (patch 1/2) should probably be
> queued up for current (4.11) and sent to stable as well (4.10 is the
> only version affected), but what about patch 2/2? Is that 4.12
Sent to stable? What serious bug it fixes?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-03-23 10:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 19:13 [PATCH v1 1/2] Revert "i2c: mux: pca954x: Add ACPI support for pca954x" Andy Shevchenko
2017-03-21 19:13 ` [PATCH v1 2/2] i2c: mux: pca954x: Allow enumeration via ACPI Andy Shevchenko
2017-03-22 10:23 ` [PATCH v1 1/2] Revert "i2c: mux: pca954x: Add ACPI support for pca954x" Peter Rosin
2017-03-22 13:05 ` Andy Shevchenko
2017-03-23 7:45 ` Peter Rosin
2017-03-23 10:04 ` Pavel Machek [this message]
2017-03-23 11:21 ` Peter Rosin
2017-03-23 12:16 ` Andy Shevchenko
2017-03-24 10:21 ` Peter Rosin
2017-03-26 12:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323100403.GA9307@amd \
--to=pavel@ucw.cz \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=peda@axentia.se \
--cc=rpurdie@rpsys.net \
--cc=tnhuynh@apm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).