From: Wolfram Sang <wsa@the-dreams.de>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v4 05/10] i2c: meson: use full 12 bits for clock divider
Date: Thu, 23 Mar 2017 21:34:04 +0100 [thread overview]
Message-ID: <20170323203404.nuobb4wtgsepnilu@ninjato> (raw)
In-Reply-To: <fbc241ed-ec1e-b433-50af-5d0ebca09711@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 133 bytes --]
> + /* clock divider has 12 bits */
> + WARN_ON(div >= (1 << 12));
Do you insist on WARN_ON? I wonder what it gives over dev_err?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-03-23 20:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 21:42 [PATCH v4 00/10] i2c: meson: series with improvements Heiner Kallweit
2017-03-14 21:50 ` [PATCH v4 01/10] i2c: meson: use min instead of min_t where min_t isn't needed Heiner Kallweit
2017-03-14 21:50 ` [PATCH v4 02/10] i2c: meson: remove member irq from struct meson_i2c Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 04/10] i2c: meson: use i2c core for DT clock-frequency parsing Heiner Kallweit
2017-03-23 20:33 ` Wolfram Sang
2017-03-24 6:47 ` Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 05/10] i2c: meson: use full 12 bits for clock divider Heiner Kallweit
2017-03-23 20:34 ` Wolfram Sang [this message]
2017-03-24 6:49 ` Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 06/10] i2c: meson: remove variable count from meson_i2c_xfer Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 07/10] i2c: meson: improve interrupt handler and detect spurious interrupts Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 08/10] i2c: meson: don't create separate token chain just for the stop command Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 09/10] i2c: meson: remove meson_i2c_write_tokens Heiner Kallweit
2017-03-14 21:51 ` [PATCH v4 10/10] i2c: meson: improve and simplify interrupt handler Heiner Kallweit
2017-03-14 21:53 ` [PATCH v4 03/10] i2c: meson: set clock divider in probe instead of setting it for each transfer Heiner Kallweit
2017-03-23 20:31 ` Wolfram Sang
2017-03-24 6:45 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323203404.nuobb4wtgsepnilu@ninjato \
--to=wsa@the-dreams.de \
--cc=hkallweit1@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox