From: Wolfram Sang <wsa@the-dreams.de>
To: "Tan, Chin Yew" <chin.yew.tan@intel.com>
Cc: "jarkko.nikula@linux.intel.com" <jarkko.nikula@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI
Date: Mon, 27 Mar 2017 12:07:28 +0200 [thread overview]
Message-ID: <20170327100728.GB2150@katana> (raw)
In-Reply-To: <1E48613D81AD0745B344B23C7C5E26B00100E44A@PGSMSX103.gar.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 382 bytes --]
> > > This describes why you change NULL to dev->sda_hold_time. But it
> > > doesn't say why you introduce the switch-block instead of populating
> > > all fields like it was done before.
> Instead of loading all speed mode settings, switch block is used to load the
> required settings for selected speed mode.
Thanks. Please add this sentence to the commit message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-03-27 10:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 5:54 [PATCH v2] Set sda-hold-time based on ACPI *CNT value chin.yew.tan
2017-02-14 5:54 ` [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI chin.yew.tan
2017-02-14 7:00 ` Jarkko Nikula
2017-03-06 12:30 ` Tan, Chin Yew
2017-02-14 10:05 ` Andy Shevchenko
2017-03-23 20:58 ` Wolfram Sang
2017-03-23 21:00 ` Wolfram Sang
2017-03-27 9:43 ` Tan, Chin Yew
2017-03-27 10:07 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-28 8:48 [PATCH V3] Set sda-hold-time based on ACPI *CNT value Tan Chin Yew
2017-03-28 8:48 ` [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI Tan Chin Yew
2017-03-28 9:13 ` Andy Shevchenko
2017-03-31 12:12 ` Jarkko Nikula
2017-04-19 18:57 ` Wolfram Sang
2017-02-10 11:28 [PATCH] Set sda-hold-time based on ACPI *CNT value chin.yew.tan
2017-02-10 11:28 ` [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI chin.yew.tan
2017-02-10 12:28 ` Jarkko Nikula
2017-02-10 12:31 ` Andy Shevchenko
2017-02-13 8:41 ` Tan, Chin Yew
2017-02-13 9:33 ` Jarkko Nikula
2017-02-13 10:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327100728.GB2150@katana \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chin.yew.tan@intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox