From: Darren Hart <dvhart@infradead.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Wolfram Sang <wsa@the-dreams.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>,
linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 4/4] platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver
Date: Wed, 5 Apr 2017 08:41:46 -0700 [thread overview]
Message-ID: <20170405154146.GD27833@fury> (raw)
In-Reply-To: <1491400346.24567.5.camel@linux.intel.com>
On Wed, Apr 05, 2017 at 04:52:26PM +0300, Andy Shevchenko wrote:
> On Wed, 2017-04-05 at 00:03 +0200, Hans de Goede wrote:
> > The INT33FE ACPI device has a CRS table with I2cSerialBusV2 resources
> > for
> > 3 devices: Maxim MAX17047 Fuel Gauge Controller, FUSB300C USB Type-C
> > Controller and PI3USB30532 USB switch.
> >
> > This commit adds a driver for this ACPI device which instantiates
> > i2c-clients for these, so that the standard i2c drivers for these
> > chips
> > can bind to the them.
> >
>
> Looks like we need something such as MFD for I2C bus clients...
>
> FWIW:
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Wolfram, will you be making an immutable i2c branch available for us to merge
into our platform driver x86 for-next branch in order to apply this patch?
Alternatively you could send this in on our behalf, but that complicates any
fixes between now and rc1 for this new driver. We'd prefer the immutable branch
and pull this in ourselves.
Either way,
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
Thanks,
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-04-05 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 22:03 [PATCH v5 0/4] i2c-core improvements for acpi devices + ACPI INT33FE driver Hans de Goede
2017-04-04 22:03 ` [PATCH v5 1/4] i2c: core: Allow getting ACPI info by index Hans de Goede
2017-04-16 20:08 ` Wolfram Sang
2017-04-04 22:03 ` [PATCH v5 2/4] i2c: core: Add new i2c_acpi_new_device helper function Hans de Goede
2017-04-16 20:08 ` Wolfram Sang
2017-04-04 22:03 ` [PATCH v5 3/4] i2c: core: Allow drivers to disable i2c-core irq mapping Hans de Goede
2017-04-05 13:31 ` Andy Shevchenko
2017-04-16 20:08 ` Wolfram Sang
2017-04-04 22:03 ` [PATCH v5 4/4] platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver Hans de Goede
2017-04-05 13:52 ` Andy Shevchenko
2017-04-05 15:41 ` Darren Hart [this message]
2017-04-16 20:08 ` Wolfram Sang
2017-04-17 22:40 ` Darren Hart
2017-04-13 19:09 ` [PATCH v5 0/4] i2c-core improvements for acpi devices + ACPI INT33FE driver Darren Hart
2017-04-14 12:34 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170405154146.GD27833@fury \
--to=dvhart@infradead.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).