From: Wolfram Sang <wsa@the-dreams.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Darren Hart <dvhart@infradead.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>,
linux-i2c@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 3/4] i2c: core: Allow drivers to disable i2c-core irq mapping
Date: Sun, 16 Apr 2017 22:08:35 +0200 [thread overview]
Message-ID: <20170416200835.og6flptm3p4joa57@ninjato> (raw)
In-Reply-To: <20170404220335.9815-4-hdegoede@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 924 bytes --]
On Wed, Apr 05, 2017 at 12:03:34AM +0200, Hans de Goede wrote:
> By default the i2c-core will try to get an irq with index 0 on ACPI / of
> instantiated devices. This is troublesome on some ACPI systems where the
> irq info at index 0 in the CRS table may contain nonsense and/or point
> to an irqchip for which there is no Linux driver.
>
> If this happens then before this commit the driver's probe method would
> never get called because i2c_device_probe will try to get an irq by
> calling acpi_dev_gpio_irq_get which will always return -EPROBE in this
> case, as it waits for a matching irqchip driver to load. Thus causing
> the driver to not get a chance to bind.
>
> This commit adds a new disable_i2c_core_irq_mapping flag to struct
> i2c_driver which a driver can set to tell the core to skip irq mapping.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-16 20:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 22:03 [PATCH v5 0/4] i2c-core improvements for acpi devices + ACPI INT33FE driver Hans de Goede
2017-04-04 22:03 ` [PATCH v5 1/4] i2c: core: Allow getting ACPI info by index Hans de Goede
2017-04-16 20:08 ` Wolfram Sang
2017-04-04 22:03 ` [PATCH v5 2/4] i2c: core: Add new i2c_acpi_new_device helper function Hans de Goede
2017-04-16 20:08 ` Wolfram Sang
2017-04-04 22:03 ` [PATCH v5 3/4] i2c: core: Allow drivers to disable i2c-core irq mapping Hans de Goede
2017-04-05 13:31 ` Andy Shevchenko
2017-04-16 20:08 ` Wolfram Sang [this message]
2017-04-04 22:03 ` [PATCH v5 4/4] platform/x86: Add Intel Cherry Trail ACPI INT33FE device driver Hans de Goede
2017-04-05 13:52 ` Andy Shevchenko
2017-04-05 15:41 ` Darren Hart
2017-04-16 20:08 ` Wolfram Sang
2017-04-17 22:40 ` Darren Hart
2017-04-13 19:09 ` [PATCH v5 0/4] i2c-core improvements for acpi devices + ACPI INT33FE driver Darren Hart
2017-04-14 12:34 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170416200835.og6flptm3p4joa57@ninjato \
--to=wsa@the-dreams.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox