linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [RFC] i2c: rcar: reinit hardware on resume
Date: Tue, 18 Apr 2017 09:07:49 +0200	[thread overview]
Message-ID: <20170418070748.GA1431@katana> (raw)
In-Reply-To: <87y3uyy2sl.wl%kuninori.morimoto.gx@renesas.com>

[-- Attachment #1: Type: text/plain, Size: 554 bytes --]


> Thus, just calling rcar_i2c_init() is not enough ?

Yes, where is my brown paper bag...

I noticed this yesterday as well before falling asleep... ;)

> But in my opinion, all register settings should be merged in one please
> (= transfer function) and call pm_runtime_get/put there only.
> R-Car I2C is not related, but I2C power domain might be
> power OFF if SoC has power domain control feature (SH-Mobile has it).

OK, so you want this feture even if R-Car is not affected? No problem,
just want to make sure. But yes, this is a seperate patch.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2017-04-18  7:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 18:32 [RFC] i2c: rcar: reinit hardware on resume Wolfram Sang
2017-04-18  0:35 ` Kuninori Morimoto
2017-04-18  7:07   ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418070748.GA1431@katana \
    --to=wsa@the-dreams.de \
    --cc=geert@linux-m68k.org \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).