From: Wolfram Sang <wsa@the-dreams.de>
To: Jan Glauber <jan.glauber@caviumnetworks.com>
Cc: Wolfram Sang <wsa-dev@sang-engineering.com>,
linux-i2c@vger.kernel.org,
Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Subject: Re: [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON
Date: Thu, 20 Apr 2017 17:55:29 +0200 [thread overview]
Message-ID: <20170420155529.riir2yqhddj4y7lj@ninjato> (raw)
In-Reply-To: <20170420091632.GA8383@hc>
[-- Attachment #1: Type: text/plain, Size: 635 bytes --]
Hi Jan,
> We do want auto-detection, so either this text is wrong or setting
> I2C_CLASS_HWMON in our i2c adapter is correct. Am I missing
> something?
I was assuming the pci-driver could ACPI for device instantiation, and
the platdrv could use DT. Then, the adapter class usage raised my
eyebrow.
I just saw that the pci-driver does not have ACPI support, yet. So, the
class could be used. Not sure about the platdrv case? But even then, the
adapter will probe EVERY hwmon device as soon as its i2c client driver
loads. Do you really want that? This may cost boot time, has unneeded
traffic on the bus, etc.
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-04-20 15:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 9:31 [PATCH 0/4] i2c octeon & thunderx bug fixes Jan Glauber
2016-12-09 9:31 ` [PATCH 1/4] i2c: octeon: thunderx: TWSI software reset in recovery Jan Glauber
2016-12-11 22:01 ` Wolfram Sang
2016-12-09 9:31 ` [PATCH 2/4] i2c: octeon: thunderx: Remove double-check after interrupt Jan Glauber
2016-12-11 22:01 ` Wolfram Sang
2016-12-09 9:31 ` [PATCH 3/4] i2c: octeon: thunderx: Limit register access retries Jan Glauber
2016-12-11 22:01 ` Wolfram Sang
2016-12-12 16:07 ` Jan Glauber
2016-12-13 20:32 ` Wolfram Sang
2016-12-17 18:29 ` Wolfram Sang
2016-12-09 9:31 ` [PATCH 4/4] i2c: octeon: thunderx: Add I2C_CLASS_HWMON Jan Glauber
2016-12-11 22:04 ` Wolfram Sang
2017-01-25 20:49 ` Wolfram Sang
2017-01-26 6:10 ` Jan Glauber
2017-04-20 9:16 ` Jan Glauber
2017-04-20 15:55 ` Wolfram Sang [this message]
2017-04-20 17:27 ` Jan Glauber
2017-04-21 6:29 ` Wolfram Sang
2017-04-21 14:31 ` Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420155529.riir2yqhddj4y7lj@ninjato \
--to=wsa@the-dreams.de \
--cc=Vadim.Lomovtsev@caviumnetworks.com \
--cc=jan.glauber@caviumnetworks.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox