From: Wolfram Sang <wsa@the-dreams.de>
To: Hoan Tran <hotran@apm.com>
Cc: linux-i2c@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Loc Ho <lho@apm.com>, Keyur Chudgar <kchudgar@apm.com>
Subject: Re: [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox
Date: Fri, 21 Apr 2017 08:31:57 +0200 [thread overview]
Message-ID: <20170421063156.GB1434@katana> (raw)
In-Reply-To: <CAFHUOYxfivQ6kQwBwyX5X8QESbCFo4E_KM5iFHyjuChtTZq+uQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
> > I think it doesn't make sense to print a dev_err and return ENODEV which
> > is treated by the driver core as a non-error. It means "not present, but
> > OK". You probably want other error codes here.
>
> How about -EINVAL for these -ENODEV error codes? Do you have any suggestion?
-EINVAL will do, I would go for -ENOENT, probably. But it doesn't matter
much.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-04-21 6:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 20:46 [PATCH 0/2] i2c: xgene-slimpro: Add ACPI support Hoan Tran
2017-03-28 20:46 ` [PATCH 1/2] i2c: xgene-slimpro: Use a single function to send command message Hoan Tran
2017-03-28 20:46 ` [PATCH 2/2] i2c: xgene-slimpro: Add ACPI support by using PCC mailbox Hoan Tran
2017-04-20 8:05 ` Wolfram Sang
2017-04-20 20:38 ` Hoan Tran
2017-04-21 6:31 ` Wolfram Sang [this message]
2017-04-17 16:36 ` [PATCH 0/2] i2c: xgene-slimpro: Add ACPI support Hoan Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421063156.GB1434@katana \
--to=wsa@the-dreams.de \
--cc=hotran@apm.com \
--cc=kchudgar@apm.com \
--cc=lho@apm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).