From: Wolfram Sang <wsa@the-dreams.de>
To: tnhuynh@apm.com
Cc: linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org, Loc Ho <lho@apm.com>,
Phong Vo <pvo@apm.com>,
patches@apm.com
Subject: Re: [PATCH V1] i2c: xgene: Add support for I2C_FUNC_I2C functionality
Date: Tue, 16 May 2017 23:36:41 +0200 [thread overview]
Message-ID: <20170516213640.2t57hdumkzxcdw5o@ninjato> (raw)
In-Reply-To: <1493181705-18531-1-git-send-email-tnhuynh@apm.com>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Wed, Apr 26, 2017 at 11:41:45AM +0700, tnhuynh@apm.com wrote:
> From: Tin Huynh <tnhuynh@apm.com>
>
> Certain I2C slave drivers, such as the pca95xx, require
> only I2C operations instead of SMBus extensions.
> This patch adds I2C_FUNC_I2C functionally to support those drivers.
No Signed-off, please run checkpatch on your patches!
> - return I2C_FUNC_SMBUS_BYTE |
> + return I2C_FUNC_I2C |
> + I2C_FUNC_SMBUS_BYTE |
Does this really work? You don't have a master_xfer function, so I think
it cannot work. You don't seem to have I2C_FUNC_I2C support in your driver.
> I2C_FUNC_SMBUS_BYTE_DATA |
> I2C_FUNC_SMBUS_WORD_DATA |
> I2C_FUNC_SMBUS_BLOCK_DATA |
> --
> 1.7.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-16 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 4:41 [PATCH V1] i2c: xgene: Add support for I2C_FUNC_I2C functionality tnhuynh
2017-05-16 21:36 ` Wolfram Sang [this message]
2017-05-16 21:39 ` Wolfram Sang
2017-05-16 21:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516213640.2t57hdumkzxcdw5o@ninjato \
--to=wsa@the-dreams.de \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=tnhuynh@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox