From: Wolfram Sang <wsa@the-dreams.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: stub: move module_init/exit annotations to the proper place
Date: Thu, 18 May 2017 10:14:35 +0200 [thread overview]
Message-ID: <20170518081435.l4em4ntmgmdu4mps@ninjato> (raw)
In-Reply-To: <20170518095842.7f3b612a@endymion>
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
Hi Jean,
> > -module_init(i2c_stub_init);
> > -module_exit(i2c_stub_exit);
>
> I'm not sure on what you base your claim that this is the "proper
> place". checkpatch doesn't complain about either, and if anything, the
> original style (module_init/exit) at end of file seems a lot more
> popular through the kernel tree.
In my book, this is more "old-style" than "popular" ;) And while I am
quite sure my change is common these days (put annotations directly
behind the functions), I in deed cannot find any public reference for
that.
No strong feelings, I can drop it.
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-05-18 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 11:21 [PATCH 1/2] i2c: stub: move module_init/exit annotations to the proper place Wolfram Sang
2017-05-16 11:21 ` [PATCH 2/2] i2c: stub: use pr_fmt Wolfram Sang
2017-05-18 8:39 ` Jean Delvare
2017-06-02 20:49 ` Wolfram Sang
2017-05-18 7:58 ` [PATCH 1/2] i2c: stub: move module_init/exit annotations to the proper place Jean Delvare
2017-05-18 8:14 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518081435.l4em4ntmgmdu4mps@ninjato \
--to=wsa@the-dreams.de \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox