From: Michael Thalmeier <michael.thalmeier@hale.at>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Marek Vasut <marex@denx.de>,
michael@thalmeier.at
Subject: [PATCH] i2c: mxs: dont print error on NAK
Date: Thu, 18 May 2017 16:14:50 +0200 [thread overview]
Message-ID: <20170518141450.30938-1-michael.thalmeier@hale.at> (raw)
When mxs_i2c_pio_wait_xfer_end returns with a return code of -ENXIO, the
NO_SLAVE_ACK_IRQ bit is set in CTRL1.
In this case, do not print an error message, because every NAK would
otherwise generate a new message.
Signed-off-by: Michael Thalmeier <michael.thalmeier@hale.at>
---
drivers/i2c/busses/i2c-mxs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index 5738556..e2dbb9c 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses/i2c-mxs.c
@@ -527,7 +527,7 @@ static int mxs_i2c_pio_setup_xfer(struct i2c_adapter *adap,
/* Wait for the end of the transfer. */
ret = mxs_i2c_pio_wait_xfer_end(i2c);
- if (ret) {
+ if (ret && ret != -ENXIO) {
dev_err(i2c->dev,
"PIO: Failed to finish WRITE cmd!\n");
break;
--
2.9.2
next reply other threads:[~2017-05-18 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 14:14 Michael Thalmeier [this message]
2017-05-19 12:44 ` [PATCH] i2c: mxs: dont print error on NAK Wolfram Sang
2017-05-31 9:40 ` [PATCH] i2c: mxs: change error printing to debug for mxs_i2c_pio_wait_xfer_end Michael Thalmeier
2017-06-02 20:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518141450.30938-1-michael.thalmeier@hale.at \
--to=michael.thalmeier@hale.at \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=michael@thalmeier.at \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).