[PATCH 0/1] gpu: move include files out of include/linux/i2c

[PATCH 0/1] gpu: move include files out of include/linux/i2c

[Wolfram Sang]

It doesn't make sense to use include/linux/i2c for client drivers which may in
fact rather be hwmon or input or whatever devices. As a result, I want to
deprecate include/linux/i2c for good. This series moves the include files to a
better location, largely include/linux/platform_data because that is what most
of the moved include files contain. Please let me know if you think another
location is more suitable.

I prefer the series to go upstream via the subsystem tree; if you prefer that I
take it via I2C, just let me know.

No runtime testing because of no HW, but buildbot is happy with this series at
least. A branch can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data

Thanks and kind regards,

   Wolfram


Wolfram Sang (1):
  gpu: drm: tc35876x: move header file out of I2C realm

 arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c | 2 +-
 drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c                  | 2 +-
 include/linux/{i2c => platform_data}/tc35876x.h             | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename include/linux/{i2c => platform_data}/tc35876x.h (100%)

-- 
2.11.0

[PATCH 1/1] gpu: drm: tc35876x: move header file out of I2C realm

[Wolfram Sang]

include/linux/i2c is not for client devices. Move the header file to a
more appropriate location.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c | 2 +-
 drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c                  | 2 +-
 include/linux/{i2c => platform_data}/tc35876x.h             | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename include/linux/{i2c => platform_data}/tc35876x.h (100%)

diff --git a/arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c b/arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c
index b1526b95fd43ac..2905376559f160 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c
@@ -11,7 +11,7 @@
  */
 
 #include <linux/gpio.h>
-#include <linux/i2c/tc35876x.h>
+#include <linux/platform_data/tc35876x.h>
 #include <asm/intel-mid.h>
 
 /*tc35876x DSI_LVDS bridge chip and panel platform data*/
diff --git a/drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c b/drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c
index 771ff66711af78..37c997e24b9ebb 100644
--- a/drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c
+++ b/drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c
@@ -26,7 +26,7 @@
 #include "mdfld_output.h"
 #include "mdfld_dsi_pkg_sender.h"
 #include "tc35876x-dsi-lvds.h"
-#include <linux/i2c/tc35876x.h>
+#include <linux/platform_data/tc35876x.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <asm/intel_scu_ipc.h>
diff --git a/include/linux/i2c/tc35876x.h b/include/linux/platform_data/tc35876x.h
similarity index 100%
rename from include/linux/i2c/tc35876x.h
rename to include/linux/platform_data/tc35876x.h
-- 
2.11.0

Re: [PATCH 0/1] gpu: move include files out of include/linux/i2c

[Patrik Jakobsson]

On Mon, May 22, 2017 at 12:11 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> It doesn't make sense to use include/linux/i2c for client drivers which may in
> fact rather be hwmon or input or whatever devices. As a result, I want to
> deprecate include/linux/i2c for good. This series moves the include files to a
> better location, largely include/linux/platform_data because that is what most
> of the moved include files contain. Please let me know if you think another
> location is more suitable.
>
> I prefer the series to go upstream via the subsystem tree; if you prefer that I
> take it via I2C, just let me know.

I don't think it makes sense to take this through the drm/gma500 since
it's platform data and does not really touch any gma500 specifics.
What makes sense for I2C/platform is probably more important here.

>
> No runtime testing because of no HW, but buildbot is happy with this series at
> least. A branch can be found here:

Not sure anybody have hardware to test mdfld + tc358765. Perhaps some
smartphone exists but I've never seen one.

FWIW, for the small gma500 change you have my:

Acked-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

Cheers

>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/platform_data
>
> Thanks and kind regards,
>
>    Wolfram
>
>
> Wolfram Sang (1):
>   gpu: drm: tc35876x: move header file out of I2C realm
>
>  arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c | 2 +-
>  drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c                  | 2 +-
>  include/linux/{i2c => platform_data}/tc35876x.h             | 0
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename include/linux/{i2c => platform_data}/tc35876x.h (100%)
>
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/1] gpu: move include files out of include/linux/i2c

[Wolfram Sang]

[-- Attachment #1.1: Type: text/plain, Size: 1489 bytes --]

On Mon, Jun 05, 2017 at 11:38:08PM +0200, Patrik Jakobsson wrote:
> On Mon, May 22, 2017 at 12:11 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> > It doesn't make sense to use include/linux/i2c for client drivers which may in
> > fact rather be hwmon or input or whatever devices. As a result, I want to
> > deprecate include/linux/i2c for good. This series moves the include files to a
> > better location, largely include/linux/platform_data because that is what most
> > of the moved include files contain. Please let me know if you think another
> > location is more suitable.
> >
> > I prefer the series to go upstream via the subsystem tree; if you prefer that I
> > take it via I2C, just let me know.
> 
> I don't think it makes sense to take this through the drm/gma500 since
> it's platform data and does not really touch any gma500 specifics.
> What makes sense for I2C/platform is probably more important here.

Ok, thank you for the info! I will pick it then.

> > No runtime testing because of no HW, but buildbot is happy with this series at
> > least. A branch can be found here:
> 
> Not sure anybody have hardware to test mdfld + tc358765. Perhaps some
> smartphone exists but I've never seen one.

There seems to be an upstream user:

arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c

> FWIW, for the small gma500 change you have my:
> 
> Acked-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>

Thanks again,

   Wolfram


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel