From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] i2c: rcar: use correct length when unmapping DMA
Date: Tue, 30 May 2017 06:49:49 +0200 [thread overview]
Message-ID: <20170530044949.GA7484@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20170528075217.1214-1-wsa+renesas@sang-engineering.com>
On 2017-05-28 09:52:17 +0200, Wolfram Sang wrote:
> Because we need to transfer some bytes with PIO, the msg length is not
> the length of the DMA buffer. Use the correct value which we used when
> doing the mapping.
>
> Fixes: 73e8b0528346e8 ("i2c: rcar: add DMA support")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/i2c/busses/i2c-rcar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c
> index 214bf2835d1f95..8be3e6cb8fe686 100644
> --- a/drivers/i2c/busses/i2c-rcar.c
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -319,7 +319,7 @@ static void rcar_i2c_dma_unmap(struct rcar_i2c_priv *priv)
> rcar_i2c_write(priv, ICFBSCR, TCYC06);
>
> dma_unmap_single(chan->device->dev, sg_dma_address(&priv->sg),
> - priv->msg->len, priv->dma_direction);
> + sg_dma_len(&priv->sg), priv->dma_direction);
>
> priv->dma_direction = DMA_NONE;
> }
> --
> 2.11.0
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2017-05-30 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-28 7:52 [PATCH] i2c: rcar: use correct length when unmapping DMA Wolfram Sang
2017-05-29 9:11 ` Geert Uytterhoeven
2017-05-30 4:49 ` Niklas Söderlund [this message]
2017-06-15 13:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170530044949.GA7484@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).