From: Lee Jones <lee.jones@linaro.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, Steven Miao <realmz6@gmail.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
adi-buildroot-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] video: adp8860: move header file out of I2C realm
Date: Fri, 9 Jun 2017 08:49:00 +0100 [thread overview]
Message-ID: <20170609074900.owjczluv7kkoso3f@dell> (raw)
In-Reply-To: <20170609074345.v5jkajra5qdsn2x7@dell>
On Fri, 09 Jun 2017, Lee Jones wrote:
> On Mon, 22 May 2017, Wolfram Sang wrote:
>
> > include/linux/i2c is not for client devices. Move the header file to a
> > more appropriate location.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> > arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
> > drivers/video/backlight/adp8860_bl.c | 2 +-
> > include/linux/{i2c => platform_data}/adp8860.h | 0
> > 3 files changed, 2 insertions(+), 2 deletions(-)
> > rename include/linux/{i2c => platform_data}/adp8860.h (100%)
>
> Applied, thanks.
Scrap that. I can't actually apply these without Steven's Ack.
> > diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> > index 24985e658c19cd..7db90c72bd8ddc 100644
> > --- a/arch/blackfin/mach-bf537/boards/stamp.c
> > +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> > @@ -2047,7 +2047,7 @@ static struct adp8870_backlight_platform_data adp8870_pdata = {
> > #endif
> >
> > #if IS_ENABLED(CONFIG_BACKLIGHT_ADP8860)
> > -#include <linux/i2c/adp8860.h>
> > +#include <linux/platform_data/adp8860.h>
> > static struct led_info adp8860_leds[] = {
> > {
> > .name = "adp8860-led7",
> > diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> > index 510e559c060e59..e7315bf14d6015 100644
> > --- a/drivers/video/backlight/adp8860_bl.c
> > +++ b/drivers/video/backlight/adp8860_bl.c
> > @@ -18,7 +18,7 @@
> > #include <linux/slab.h>
> > #include <linux/workqueue.h>
> >
> > -#include <linux/i2c/adp8860.h>
> > +#include <linux/platform_data/adp8860.h>
> > #define ADP8860_EXT_FEATURES
> > #define ADP8860_USE_LEDS
> >
> > diff --git a/include/linux/i2c/adp8860.h b/include/linux/platform_data/adp8860.h
> > similarity index 100%
> > rename from include/linux/i2c/adp8860.h
> > rename to include/linux/platform_data/adp8860.h
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-06-09 7:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 22:09 [PATCH 0/2] video: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 22:09 ` [PATCH 1/2] video: adp8860: move header file out of I2C realm Wolfram Sang
2017-05-29 9:22 ` Bartlomiej Zolnierkiewicz
2017-06-07 10:57 ` Daniel Thompson
2017-06-07 12:10 ` Michael Hennerich
2017-06-09 7:43 ` Lee Jones
2017-06-09 7:49 ` Lee Jones [this message]
2017-05-21 22:09 ` [PATCH 2/2] video: adp8870: " Wolfram Sang
2017-05-29 9:23 ` Bartlomiej Zolnierkiewicz
2017-06-07 10:57 ` Daniel Thompson
2017-06-09 7:43 ` Lee Jones
2017-06-09 7:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609074900.owjczluv7kkoso3f@dell \
--to=lee.jones@linaro.org \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=realmz6@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).