* [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it
@ 2017-06-15 18:49 Javier Martinez Canillas
[not found] ` <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-06-15 18:49 UTC (permalink / raw)
To: linux-kernel
Cc: devicetree, Wolfram Sang, Rob Herring, Tony Lindgren, Lee Jones,
Aaro Koskinen, Javier Martinez Canillas, Benoît Cousson,
Linus Walleij, Mark Rutland, linux-omap, Russell King,
linux-arm-kernel, linux-i2c
Hello,
This series add OF device ID tables to mfd I2C drivers whose devices are
either used in Device Tree source files or are listed in binding docs as
a compatible string.
That's done because the plan is to change the I2C core to report proper OF
modaliases instead of always reporting a MODALIAS=i2c:<foo> regardless if
a device was registered via DT or using the legacy platform data mechanism.
So these patches will make sure that mfd I2C drivers modules will continue
to be autoloaded once the I2C core is changed to report proper OF modalias.
Users didn't have a vendor prefix in the used compatible strings, but since
there wasn't a DT binding document for these drivers, it can be said that
were working for mere luck and so this series fixes the users and add a DT
binding doc for the drivers.
Most patches can be applied independently, with the exception of patches
2 to 4 that should be applied in the same tree to keep bisect-ability. I
suggest these to go through the MFD subsystem tree.
Best regards,
Javier
Changes in v6:
- Mention CBUS address instead of I2C since that's the bus used (Wolfram Sang).
- Add a "i2c-cbus-gpio" comptible and use cbus0 for parent node (Wolfram Sang).
- Add Wolfram Sang's Reviewed-by tag.
- Add Wolfram Sang's Reviewed-by tag.
- Add Wolfram Sang's Reviewed-by tag.
- Add Wolfram Sang's Reviewed-by tag.
Changes in v5:
- Add missing properties for interrupts to DT binding doc (Rob Herring).
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
- Add Lee Jones <lee.jones@linaro.org>'s Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Tony Lindgren's Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
- Add Lee Jones <lee.jones@linaro.org>'s Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
- Add Lee Jones <lee.jones@linaro.org>'s Acked-by tag.
- Add Rob Herring's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony@atomide.com>'s Acked-by tag.
Changes in v4:
- Use "dt-bindings: mfd:" prefix in subject line (Rob Herring).
- Add information about what functions the device serve (Lee Jones).
- Avoid using MFD in Device Tree (Lee Jones).
- Drop -mfd suffix in compatible string (Lee Jones).
- Avoid using MFD in Device Tree (Lee Jones).
- Use "dt-bindings: mfd:" prefix in subject line (Rob Herring).
- Add information about what functions the device serve (Lee Jones).
Changes in v3:
- Add a vendor prefix to the compatible string (Rob Herring).
- Add a vendor prefix to the compatible string (Rob Herring).
Changes in v2:
- Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
- Don't use of_match_ptr() to avoid build warning when CONFIG_OF is disabled.
Javier Martinez Canillas (8):
dt-bindings: mfd: Add retu/tahvo ASIC chips bindings
mfd: retu: Drop -mfd suffix from I2C device ID name
mfd: retu: Add OF device ID table
ARM: dts: n8x0: Add vendor prefix to retu node
i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example
dt-bindings: mfd: Add TI tps6105x chip bindings
mfd: tps6105x: Add OF device ID table
ARM: ux500: Add vendor prefix to tps61052 node
.../devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
Documentation/devicetree/bindings/mfd/retu.txt | 25 ++++++++++++++++++++++
Documentation/devicetree/bindings/mfd/tps6105x.txt | 17 +++++++++++++++
arch/arm/boot/dts/omap2420-n8x0-common.dtsi | 4 ++--
arch/arm/boot/dts/ste-hrefprev60.dtsi | 2 +-
arch/arm/mach-omap1/board-nokia770.c | 4 ++--
drivers/mfd/retu-mfd.c | 12 +++++++++--
drivers/mfd/tps6105x.c | 8 +++++++
8 files changed, 67 insertions(+), 9 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt
create mode 100644 Documentation/devicetree/bindings/mfd/tps6105x.txt
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND PATCH v6 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example
[not found] ` <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
@ 2017-06-15 18:49 ` Javier Martinez Canillas
0 siblings, 0 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-06-15 18:49 UTC (permalink / raw)
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Wolfram Sang, Rob Herring,
Tony Lindgren, Lee Jones, Aaro Koskinen, Javier Martinez Canillas,
linux-i2c-u79uwXL29TY76Z2rM5mHXA, Mark Rutland
The example contains a device node for a retu device, but
its compatible string doesn't have a vendor prefix.
While being there, drop the -mfd suffix since isn't correct.
Signed-off-by: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Acked-by: Aaro Koskinen <aaro.koskinen-X3B1VOXEql0@public.gmane.org>
Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
---
Changes in v6:
- Add Wolfram Sang's Reviewed-by tag.
Changes in v5:
- Add Rob Herring's Acked-by tag.
- Add Aaro Koskinen's Acked-by tag.
- Add Acked-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>'s Acked-by tag.
Changes in v4:
- Avoid using MFD in Device Tree (Lee Jones).
Changes in v3: None
Changes in v2: None
Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
index 8ce9cd2855b5..c143948b2a37 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-cbus-gpio.txt
@@ -20,8 +20,8 @@ i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
- retu-mfd: retu@1 {
- compatible = "retu-mfd";
+ retu: retu@1 {
+ compatible = "nokia,retu";
reg = <0x1>;
};
};
--
2.9.3
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it
2017-06-15 18:49 [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
[not found] ` <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
@ 2017-07-10 7:40 ` Javier Martinez Canillas
2017-07-10 8:07 ` Lee Jones
2017-07-18 8:04 ` [GIT PULL] Immutable branch between MFD, ARM and I2C due for the v4.14 merge window Lee Jones
2 siblings, 1 reply; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-07-10 7:40 UTC (permalink / raw)
To: Lee Jones
Cc: Linux Kernel, devicetree@vger.kernel.org, Wolfram Sang,
Rob Herring, Tony Lindgren, Aaro Koskinen,
Javier Martinez Canillas, Benoît Cousson, Linus Walleij,
Mark Rutland, linux-omap@vger.kernel.org, Russell King,
linux-arm-kernel@lists.infradead.org, Linux I2C
Hello Lee,
On Thu, Jun 15, 2017 at 8:49 PM, Javier Martinez Canillas
<javier@dowhile0.org> wrote:
>
> This series add OF device ID tables to mfd I2C drivers whose devices are
> either used in Device Tree source files or are listed in binding docs as
> a compatible string.
>
> That's done because the plan is to change the I2C core to report proper OF
> modaliases instead of always reporting a MODALIAS=i2c:<foo> regardless if
> a device was registered via DT or using the legacy platform data mechanism.
>
> So these patches will make sure that mfd I2C drivers modules will continue
> to be autoloaded once the I2C core is changed to report proper OF modalias.
>
> Users didn't have a vendor prefix in the used compatible strings, but since
> there wasn't a DT binding document for these drivers, it can be said that
> were working for mere luck and so this series fixes the users and add a DT
> binding doc for the drivers.
>
> Most patches can be applied independently, with the exception of patches
> 2 to 4 that should be applied in the same tree to keep bisect-ability. I
> suggest these to go through the MFD subsystem tree.
>
> Best regards,
> Javier
>
Are you planning to pick this series? It has been in the list for
months and were resent many times...
Best regards,
Javier
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it
2017-07-10 7:40 ` [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
@ 2017-07-10 8:07 ` Lee Jones
2017-07-10 8:34 ` Javier Martinez Canillas
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2017-07-10 8:07 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Linux Kernel, devicetree@vger.kernel.org, Wolfram Sang,
Rob Herring, Tony Lindgren, Aaro Koskinen, Benoît Cousson,
Linus Walleij, Mark Rutland, linux-omap@vger.kernel.org,
Russell King, linux-arm-kernel@lists.infradead.org, Linux I2C
On Mon, 10 Jul 2017, Javier Martinez Canillas wrote:
> Hello Lee,
>
> On Thu, Jun 15, 2017 at 8:49 PM, Javier Martinez Canillas
> <javier@dowhile0.org> wrote:
> >
> > This series add OF device ID tables to mfd I2C drivers whose devices are
> > either used in Device Tree source files or are listed in binding docs as
> > a compatible string.
> >
> > That's done because the plan is to change the I2C core to report proper OF
> > modaliases instead of always reporting a MODALIAS=i2c:<foo> regardless if
> > a device was registered via DT or using the legacy platform data mechanism.
> >
> > So these patches will make sure that mfd I2C drivers modules will continue
> > to be autoloaded once the I2C core is changed to report proper OF modalias.
> >
> > Users didn't have a vendor prefix in the used compatible strings, but since
> > there wasn't a DT binding document for these drivers, it can be said that
> > were working for mere luck and so this series fixes the users and add a DT
> > binding doc for the drivers.
> >
> > Most patches can be applied independently, with the exception of patches
> > 2 to 4 that should be applied in the same tree to keep bisect-ability. I
> > suggest these to go through the MFD subsystem tree.
> >
> > Best regards,
> > Javier
> >
>
> Are you planning to pick this series? It has been in the list for
> months and were resent many times...
I think you exaggerate a little. Your last Ack (from Linus) was only
collected in v6, which has only been resent once with that Ack
applied. =:)
We are currently only half way through the merge-window. This patch
will be hoovered up during the early -rcs. Please be patient around
the time of the merge-window, since Maintainers are either usually
very busy with pull-requests, or taking a 2 minute breather before
the chaos starts over.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it
2017-07-10 8:07 ` Lee Jones
@ 2017-07-10 8:34 ` Javier Martinez Canillas
0 siblings, 0 replies; 7+ messages in thread
From: Javier Martinez Canillas @ 2017-07-10 8:34 UTC (permalink / raw)
To: Lee Jones
Cc: Linux Kernel, devicetree@vger.kernel.org, Wolfram Sang,
Rob Herring, Tony Lindgren, Aaro Koskinen, Benoît Cousson,
Linus Walleij, Mark Rutland, linux-omap@vger.kernel.org,
Russell King, linux-arm-kernel@lists.infradead.org, Linux I2C
On Mon, Jul 10, 2017 at 10:07 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 10 Jul 2017, Javier Martinez Canillas wrote:
>
>> Hello Lee,
>>
>> On Thu, Jun 15, 2017 at 8:49 PM, Javier Martinez Canillas
>> <javier@dowhile0.org> wrote:
>> >
>> > This series add OF device ID tables to mfd I2C drivers whose devices are
>> > either used in Device Tree source files or are listed in binding docs as
>> > a compatible string.
>> >
>> > That's done because the plan is to change the I2C core to report proper OF
>> > modaliases instead of always reporting a MODALIAS=i2c:<foo> regardless if
>> > a device was registered via DT or using the legacy platform data mechanism.
>> >
>> > So these patches will make sure that mfd I2C drivers modules will continue
>> > to be autoloaded once the I2C core is changed to report proper OF modalias.
>> >
>> > Users didn't have a vendor prefix in the used compatible strings, but since
>> > there wasn't a DT binding document for these drivers, it can be said that
>> > were working for mere luck and so this series fixes the users and add a DT
>> > binding doc for the drivers.
>> >
>> > Most patches can be applied independently, with the exception of patches
>> > 2 to 4 that should be applied in the same tree to keep bisect-ability. I
>> > suggest these to go through the MFD subsystem tree.
>> >
>> > Best regards,
>> > Javier
>> >
>>
>> Are you planning to pick this series? It has been in the list for
>> months and were resent many times...
>
> I think you exaggerate a little. Your last Ack (from Linus) was only
> collected in v6, which has only been resent once with that Ack
> applied. =:)
>
You are right, sorry for the impatience.
> We are currently only half way through the merge-window. This patch
> will be hoovered up during the early -rcs. Please be patient around
> the time of the merge-window, since Maintainers are either usually
> very busy with pull-requests, or taking a 2 minute breather before
> the chaos starts over.
>
Great, I just was worried that it could fell through the cracks.
Thanks for your answer.
Best regards,
Javier
^ permalink raw reply [flat|nested] 7+ messages in thread
* [GIT PULL] Immutable branch between MFD, ARM and I2C due for the v4.14 merge window
2017-06-15 18:49 [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
[not found] ` <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
2017-07-10 7:40 ` [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
@ 2017-07-18 8:04 ` Lee Jones
2017-07-27 12:21 ` Wolfram Sang
2 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2017-07-18 8:04 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, devicetree, Wolfram Sang, Rob Herring,
Tony Lindgren, Aaro Koskinen, Benoît Cousson, Linus Walleij,
Mark Rutland, linux-omap, Russell King, linux-arm-kernel,
linux-i2c
Enjoy!
The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877:
Linux v4.13-rc1 (2017-07-15 15:22:10 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-arm-i2c-v4.14
for you to fetch changes up to ea5ae803192eb2b03e0bd23db63d2f355fd23eda:
ARM: ux500: Add vendor prefix to tps61052 node (2017-07-18 08:27:46 +0100)
----------------------------------------------------------------
Immutable branch between MFD, ARM and I2C due for the v4.14 merge window
----------------------------------------------------------------
Javier Martinez Canillas (8):
dt-bindings: mfd: Add retu/tahvo ASIC chips bindings
mfd: retu: Drop -mfd suffix from I2C device ID name
ARM: dts: n8x0: Add vendor prefix to retu node
mfd: retu: Add OF device ID table
i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example
dt-bindings: mfd: Add TI tps6105x chip bindings
mfd: tps6105x: Add OF device ID table
ARM: ux500: Add vendor prefix to tps61052 node
.../devicetree/bindings/i2c/i2c-cbus-gpio.txt | 4 ++--
Documentation/devicetree/bindings/mfd/retu.txt | 25 ++++++++++++++++++++++
Documentation/devicetree/bindings/mfd/tps6105x.txt | 17 +++++++++++++++
arch/arm/boot/dts/omap2420-n8x0-common.dtsi | 4 ++--
arch/arm/boot/dts/ste-hrefprev60.dtsi | 2 +-
arch/arm/mach-omap1/board-nokia770.c | 4 ++--
drivers/mfd/retu-mfd.c | 12 +++++++++--
drivers/mfd/tps6105x.c | 8 +++++++
8 files changed, 67 insertions(+), 9 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/retu.txt
create mode 100644 Documentation/devicetree/bindings/mfd/tps6105x.txt
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [GIT PULL] Immutable branch between MFD, ARM and I2C due for the v4.14 merge window
2017-07-18 8:04 ` [GIT PULL] Immutable branch between MFD, ARM and I2C due for the v4.14 merge window Lee Jones
@ 2017-07-27 12:21 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2017-07-27 12:21 UTC (permalink / raw)
To: Lee Jones
Cc: Javier Martinez Canillas, linux-kernel, devicetree, Rob Herring,
Tony Lindgren, Aaro Koskinen, Benoît Cousson, Linus Walleij,
Mark Rutland, linux-omap, Russell King, linux-arm-kernel,
linux-i2c
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
On Tue, Jul 18, 2017 at 09:04:41AM +0100, Lee Jones wrote:
> Enjoy!
>
> The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877:
>
> Linux v4.13-rc1 (2017-07-15 15:22:10 -0700)
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-arm-i2c-v4.14
Pulled, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-07-27 12:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-15 18:49 [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
[not found] ` <20170615184928.12007-1-javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
2017-06-15 18:49 ` [RESEND PATCH v6 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example Javier Martinez Canillas
2017-07-10 7:40 ` [RESEND PATCH v6 0/8] mfd: Add OF device table to I2C drivers that are missing it Javier Martinez Canillas
2017-07-10 8:07 ` Lee Jones
2017-07-10 8:34 ` Javier Martinez Canillas
2017-07-18 8:04 ` [GIT PULL] Immutable branch between MFD, ARM and I2C due for the v4.14 merge window Lee Jones
2017-07-27 12:21 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).