From: Wolfram Sang <wsa@the-dreams.de>
To: Michail Georgios Etairidis <m.etairidis@beck-ipc.com>
Cc: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH] i2c: i2c-imx: Use correct function to write to register
Date: Mon, 19 Jun 2017 16:46:01 +0200 [thread overview]
Message-ID: <20170619144601.vhswaa27f5mcxcxs@ninjato> (raw)
In-Reply-To: <681500CE65202E47A192754B01DAB4671B16747E36@SDE12.beckipc.net>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
On Fri, Jun 09, 2017 at 03:28:12PM +0200, Michail Georgios Etairidis wrote:
> The i2c-imx driver incorrectly uses readb()/writeb() to read and write
> to the appropriate registers when performing a repeated start. The
> appropriate imx_i2c_read_reg()/imx_i2c_write_reg() functions should be
> used instead. Performing a repeated start results in a kernel panic.
On what platform? It has a different regshift, I assume. Anyone from PTX
or Freescale can confirm?
> I am resubmitting this patch as the previous one was erroneous. This
> patch is based on the current upstream kernel code.
There is no Signed-off-by. I need that. Read
Documentation/process/submit-checklist.rst if you don't know about it
yet.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-06-19 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 13:28 [PATCH] i2c: i2c-imx: Use correct function to write to register Michail Georgios Etairidis
2017-06-19 14:46 ` Wolfram Sang [this message]
2017-06-20 8:20 ` AW: " Michail Georgios Etairidis
2017-06-20 8:28 ` Uwe Kleine-König
2017-06-20 9:23 ` Wolfram Sang
2017-06-22 8:54 ` Wolfram Sang
2017-06-19 18:54 ` Uwe Kleine-König
2017-06-20 1:50 ` Andy Duan
-- strict thread matches above, loose matches on Subject: below --
2017-06-08 17:07 Michail Georgios Etairidis
[not found] <681500CE65202E47A192754B01DAB4671B16747DB9@SDE12.beckipc.net>
2017-06-08 16:43 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619144601.vhswaa27f5mcxcxs@ninjato \
--to=wsa@the-dreams.de \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=m.etairidis@beck-ipc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox