linux-i2c.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
To: wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Chris Packham
	<chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
Subject: [PATCH v2 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk
Date: Tue, 20 Jun 2017 13:18:37 +1200	[thread overview]
Message-ID: <20170620011837.14010-6-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20170620011837.14010-1-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>

Signed-off-by: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
---
 drivers/i2c/busses/i2c-pca-platform.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index 12ab0cafa7c9..27175d681548 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -107,8 +107,8 @@ static int i2c_pca_pf_waitforcompletion(void *pd)
 static void i2c_pca_pf_dummyreset(void *pd)
 {
 	struct i2c_pca_pf_data *i2c = pd;
-	printk(KERN_WARNING "%s: No reset-pin found. Chip may get stuck!\n",
-		i2c->adap.name);
+
+	dev_warn(&i2c->adap.dev, "No reset-pin found. Chip may get stuck!\n");
 }
 
 static void i2c_pca_pf_resetchip(void *pd)
@@ -214,8 +214,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 			gpio_direction_output(i2c->gpio, 1);
 			i2c->algo_data.reset_chip = i2c_pca_pf_resetchip;
 		} else {
-			printk(KERN_WARNING "%s: Registering gpio failed!\n",
-				i2c->adap.name);
+			dev_warn(&pdev->dev, "Registering gpio failed!\n");
 			i2c->gpio = ret;
 		}
 	}
@@ -233,7 +232,7 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, i2c);
 
-	printk(KERN_INFO "%s registered.\n", i2c->adap.name);
+	dev_info(&pdev->dev, "registered.\n");
 
 	return 0;
 }
-- 
2.13.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-06-20  1:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-20  1:18 [PATCH v2 0/5] i2c: pca-platform: updates Chris Packham
2017-06-20  1:18 ` [PATCH v2 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham
     [not found]   ` <20170620011837.14010-2-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-06-22  8:22     ` Wolfram Sang
2017-06-22 21:20       ` Chris Packham
     [not found]         ` <e121e9ad4afe49008e34b5b4a76b22c6-5g7mGxlPNYb6GjIOKuZY+ItlCAj8ZROq@public.gmane.org>
2017-06-23  8:17           ` Wolfram Sang
2017-06-23 21:41         ` Rob Herring
2017-06-20  1:18 ` [PATCH v2 2/5] i2c: pca-platform: add devicetree awareness Chris Packham
     [not found] ` <20170620011837.14010-1-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-06-20  1:18   ` [PATCH v2 3/5] i2c: pca-platform: use gpio_is_valid Chris Packham
2017-06-20  1:18   ` [PATCH v2 4/5] i2c: pca-platform: use device managed allocations Chris Packham
2017-06-20  1:18   ` Chris Packham [this message]
2017-06-26  0:44 ` [PATCH v3 0/5] i2c: pca-platform: updates Chris Packham
2017-06-26  0:44   ` [PATCH v3 1/5] dt-bindings: add bindings for i2c-pca-platform Chris Packham
     [not found]     ` <20170626004434.2757-2-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-06-26 14:06       ` Rob Herring
2017-06-27 19:53     ` Wolfram Sang
2017-06-26  0:44   ` [PATCH v3 2/5] i2c: pca-platform: switch to struct gpio_desc Chris Packham
2017-06-27 19:53     ` Wolfram Sang
2017-06-28  9:25     ` Andy Shevchenko
2017-06-28 21:25       ` Chris Packham
2017-06-28 22:18         ` Wolfram Sang
2017-06-26  0:44   ` [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness Chris Packham
2017-06-27 19:55     ` Wolfram Sang
2017-06-28  9:20     ` Andy Shevchenko
2017-06-28  9:42       ` Wolfram Sang
2017-06-28 21:15       ` Chris Packham
2017-06-26  0:44   ` [PATCH v3 4/5] i2c: pca-platform: use device managed allocations Chris Packham
2017-06-27 19:55     ` Wolfram Sang
2017-06-28  9:23     ` Andy Shevchenko
2017-06-28  9:38       ` Wolfram Sang
2017-06-28 10:54         ` Andy Shevchenko
2017-06-28 21:03           ` Chris Packham
2017-06-26  0:44   ` [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead of printk Chris Packham
2017-06-27 19:55     ` Wolfram Sang
2017-06-28  9:28     ` Andy Shevchenko
2017-06-28  9:37       ` Wolfram Sang
2017-06-28 10:57         ` Andy Shevchenko
2017-06-28 12:01           ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170620011837.14010-6-chris.packham@alliedtelesis.co.nz \
    --to=chris.packham-6g8wrflrtwxfdca3tkvle6u/zskkhjvu@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).